From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Vinod Koul <vinod.koul@intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH -next] soundwire: Fix typo in return value check of sdw_read()
Date: Tue, 2 Jan 2018 14:00:52 -0600 [thread overview]
Message-ID: <a77dc39a-cc5f-f41f-d4bc-7230820a9f9b@linux.intel.com> (raw)
In-Reply-To: <1514866099-108711-1-git-send-email-weiyongjun1@huawei.com>
On 1/1/18 10:08 PM, Wei Yongjun wrote:
> Fix the typo, 'status' should be instead of 'status2'.
well spotted, thanks!
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soundwire/bus.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 4c34519..266d2b3 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
> status2 = sdw_read(slave, SDW_DP0_INT);
> if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DP0_INT read failed:%d", status);
> - return status;
> + "SDW_DP0_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave,
>
> /* Read DPN interrupt again */
> status2 = sdw_read(slave, addr);
> - if (status < 0) {
> + if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DPN_INT read failed:%d", status);
> - return status;
> + "SDW_DPN_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2018-01-02 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 4:08 Wei Yongjun
2018-01-02 20:00 ` Pierre-Louis Bossart [this message]
2018-01-03 3:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a77dc39a-cc5f-f41f-d4bc-7230820a9f9b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vinod.koul@intel.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®