From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Rogier Wolff" <R.E.Wolff@bitwizard.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: nbd problem.
Date: Tue, 8 May 2007 13:33:52 -0700 [thread overview]
Message-ID: <a781481a0705081333u7b910522x5aac0a0e532d5f85@mail.gmail.com> (raw)
In-Reply-To: <20070508194053.GA23615@bitwizard.nl>
On 5/8/07, Rogier Wolff <R.E.Wolff@bitwizard.nl> wrote:
>
> Hi,
>
> The nbd client still reliably hangs when I use it.
>
> While looking into this, I found:
>
>
> 446 req->errors = 0;
> 447 spin_unlock_irq(q->queue_lock);
> ^^^^^^^^^^^^^^^^^^^^
BTW (this could be unrelated to the original issue here), but can
anybody ever have a _genuine_ excuse to use spin_lock_irq /
spin_unlock_irq and not spin_lock_irqsave / spin_unlock_restore? I
find the latter primitives more tasteful even when I *know* something
is being called with interrupts enabled / disabled -- you never know
when some code is re-used again somewhere else and/or ripped out of
one place and put inside another ... the former API only invites
trouble, if anything.
next prev parent reply other threads:[~2007-05-08 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 19:40 Rogier Wolff
2007-05-08 20:33 ` Satyam Sharma [this message]
2007-05-09 11:10 ` Rogier Wolff
2007-05-09 12:38 ` Rogier Wolff
2007-05-09 12:52 ` Jan Engelhardt
2007-05-09 13:39 ` Jens Axboe
2007-05-09 5:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0705081333u7b910522x5aac0a0e532d5f85@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=R.E.Wolff@bitwizard.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®