From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>,
"Roman Zippel" <zippel@linux-m68k.org>,
"Kumar Gala" <galak@kernel.crashing.org>,
"Simon Horman" <horms@verge.net.au>
Subject: Re: RFC: kconfig select warnings bogus?
Date: Sun, 20 May 2007 05:32:56 +0530 [thread overview]
Message-ID: <a781481a0705191702x269f7f8ev95fd3f9f7c9c1ad4@mail.gmail.com> (raw)
In-Reply-To: <20070519235116.GO6291@stusta.de>
On 5/20/07, Adrian Bunk <bunk@stusta.de> wrote:
> On Sun, May 20, 2007 at 05:11:50AM +0530, Satyam Sharma wrote:
> > On 5/20/07, Satyam Sharma <satyam.sharma@gmail.com> wrote:
> >> On 5/20/07, Adrian Bunk <bunk@stusta.de> wrote:
> >> > On Sun, May 20, 2007 at 04:47:52AM +0530, Satyam Sharma wrote:
> >> > > On 5/20/07, Adrian Bunk <bunk@stusta.de> wrote:
> >> > >> On Sun, May 20, 2007 at 04:19:12AM +0530, Satyam Sharma wrote:
> >> > >> >...
> >> > >> > A combined patch for all of those on top of 22-rc2 (adding
> >> > >> Signed-off-by's
> >> > >> > for original authors too):
> >> > >> >...
> >> > >> > --- a/arch/m68k/Kconfig 2007-05-20 04:11:47.000000000 +0530
> >> > >> > +++ b/arch/m68k/Kconfig 2007-05-20 04:23:57.000000000 +0530
> >> > >> > @@ -411,6 +411,7 @@ config STRAM_PROC
> >> > >> >
> >> > >> > config ATARI_KBD_CORE
> >> > >> > bool
> >> > >> > + default y if KEYBOARD_ATARI || MOUSE_ATARI
> >> > >> >...
> >> > >> > --- a/drivers/input/keyboard/Kconfig 2007-05-20 04:11:55.000000000
> >> > >> +0530
> >> > >> > +++ b/drivers/input/keyboard/Kconfig 2007-05-20 04:24:54.000000000
> >> > >> +0530
> >> > >> > @@ -167,7 +167,6 @@ config KEYBOARD_AMIGA
> >> > >> > config KEYBOARD_ATARI
> >> > >> > tristate "Atari keyboard"
> >> > >> > depends on ATARI
> >> > >> > - select ATARI_KBD_CORE
> >> > >> > help
> >> > >> > Say Y here if you are running Linux on any Atari and have a
> >> > >> keyboard
> >> > >> > attached.
> >> > >> > diff -ruNp a/drivers/input/mouse/Kconfig
> >> b/drivers/input/mouse/Kconfig
> >> > >> > --- a/drivers/input/mouse/Kconfig 2007-05-20 04:11:55.000000000
> >> > >> +0530
> >> > >> > +++ b/drivers/input/mouse/Kconfig 2007-05-20 04:25:09.000000000
> >> > >> +0530
> >> > >> > @@ -179,7 +179,6 @@ config MOUSE_AMIGA
> >> > >> > config MOUSE_ATARI
> >> > >> > tristate "Atari mouse"
> >> > >> > depends on ATARI
> >> > >> > - select ATARI_KBD_CORE
> >> > >> > help
> >> > >> > Say Y here if you have an Atari and want its native mouse
> >> > >> > supported by the kernel.
> >> > >> >...
> >> > >>
> >> > >> This is a good example how "fixing" the warnings makes things
> >> worse...
> >> > >
> >> > > How?
> >> >
> >> > Consider ATARI_KBD_CORE was used by 20 drivers.
> >> >
> >> > Using select for such not user visible helper variables is a really nice
> >> > thing, and much more readable (and therefore much less likely to contain
> >> > bugs) than dependencies with tons of "||"'s.
> >>
> >> Well, the "default .. if .." kind of idiom is fairly common (I could say
> >> almost standard), in arch/.../config's. It's been used for some time,
> >> and for several symbols over there. But you're right that if 20 drivers
> >> used ATARI_KBD_CORE, we'd get tons of ugly "||"'s there, so
> >> perhaps we do need some kind of fix for this.
> >
> > [ BTW ] I hope nobody gets the wrong message with the word "fix"
> > above, what you're pointing out is only a "readability" issue, not a
> > potential build breakage or any critical problem ...
>
> And what it would "fix" is only a bogus warning, not a potential build
> breakage or any critical problem ...
Yeah, as I said already, if you're saying that all four of these warnings
are bogus and don't lead to any build failures, then perhaps the patch
I sent isn't any "critical" either. Again, I can't really confirm, because
I've never tried to build these drivers, because I don't have access to
powerpc / m68k machines.
But the patch I sent does suppress bogus warnings, and does it in a
way that is fairly common / similar to the way most other similar helper
stuff are handled in arch/.../config's.
Sam's patch will also suppress warnings, but the problem there is that
it kills off checking for "select"ion of non-existent symbols _completely_,
and thus may allow build breakages to occur.
next prev parent reply other threads:[~2007-05-20 0:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 15:15 Sam Ravnborg
2007-05-19 18:09 ` Andrew Morton
2007-05-19 22:17 ` Satyam Sharma
2007-05-19 22:49 ` Satyam Sharma
2007-05-19 23:09 ` Adrian Bunk
2007-05-19 23:17 ` Satyam Sharma
2007-05-19 23:25 ` Adrian Bunk
2007-05-19 23:36 ` Satyam Sharma
2007-05-19 23:41 ` Satyam Sharma
2007-05-19 23:51 ` Adrian Bunk
2007-05-20 0:02 ` Satyam Sharma [this message]
2007-05-19 23:48 ` Adrian Bunk
2007-05-19 23:55 ` Satyam Sharma
2007-05-20 0:13 ` Adrian Bunk
2007-05-20 0:19 ` Satyam Sharma
2007-05-20 9:52 ` Trent Piepho
2007-05-20 10:58 ` Stefan Richter
2007-05-20 11:23 ` Trent Piepho
2007-05-20 11:44 ` Stefan Richter
2007-05-20 19:57 ` Trent Piepho
2007-05-20 20:12 ` Stefan Richter
2007-05-20 20:41 ` Trent Piepho
2007-05-22 15:13 ` Satyam Sharma
2007-05-20 18:30 ` Adrian Bunk
2007-05-20 0:46 ` Stefan Richter
2007-05-20 0:53 ` Satyam Sharma
2007-05-20 1:04 ` Satyam Sharma
2007-05-20 8:31 ` Stefan Richter
2007-05-20 11:38 ` Satyam Sharma
2007-05-20 11:47 ` Stefan Richter
2007-05-20 11:57 ` Satyam Sharma
2007-05-20 13:09 ` Stefan Richter
2007-05-20 13:50 ` Satyam Sharma
2007-05-20 14:39 ` Stefan Richter
2007-05-22 14:53 ` Satyam Sharma
2007-05-22 17:03 ` Stefan Richter
2007-05-22 17:13 ` Satyam Sharma
2007-05-22 17:38 ` Stefan Richter
2007-05-22 17:46 ` Satyam Sharma
2007-05-22 17:54 ` Stefan Richter
2007-05-22 17:59 ` Satyam Sharma
2007-05-20 18:23 ` Adrian Bunk
2007-05-19 23:05 ` Adrian Bunk
2007-05-19 23:17 ` Satyam Sharma
2007-05-19 23:21 ` Satyam Sharma
2007-05-19 23:29 ` Adrian Bunk
2007-05-19 23:32 ` Satyam Sharma
2007-05-19 23:23 ` Adrian Bunk
2007-05-19 23:22 ` Andrew Morton
2007-05-20 0:02 ` Adrian Bunk
2007-05-20 0:11 ` Satyam Sharma
2007-05-20 9:43 ` Russell King
2007-05-20 9:40 ` Russell King
2007-05-20 10:17 ` Sam Ravnborg
2007-05-20 11:07 ` Geert Uytterhoeven
2007-05-21 0:25 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0705191702x269f7f8ev95fd3f9f7c9c1ad4@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=galak@kernel.crashing.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®