From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Roland Dreier" <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [ofa-general] Re: dealing with gcc 'comparison is always false' warnings
Date: Wed, 30 May 2007 22:30:14 +0530 [thread overview]
Message-ID: <a781481a0705301000r35e2dde7x8c90ba7b0497e4ef@mail.gmail.com> (raw)
In-Reply-To: <adaveeaqp8q.fsf@cisco.com>
[ Sorry, the threading broke because the subject changed,
so I missed seeing this mail earlier. ]
On 5/30/07, Roland Dreier <rdreier@cisco.com> wrote:
> > However, gcc is _just as correct_. It is only crying about seeing a condition
> > that the programmer could have written with some purpose in mind but which
> > is being completely compiled away by it when generating the code because
> > of it being a tautology / contradiction ...
>
> Well, OK, but there's lots of things gcc could warn about. How about
>
> while (1) { ...
Umm ... perhaps because gcc does not compile away any code for
such cases, but only the condition? Or because gcc knows this is
a common idiom in a *lot* of C code? I don't know (or care!) ... the
precise cases for which the warning is emitted would be known only
by reading gcc sources (which I have no intention of doing :-)
> By your argument gcc should warn that '1' always evaluates to true.
Note that my "argument" was about conditions that weren't as
simplistic as #if 0 or while (1) and that involved not merely 1 or 0,
but variables whose values might not be available at compile-time ...
> Or how about
>
> #if 0
>
> why shouldn't the preprocessor warn that the conditional is always false?
Perhaps because gcc knows programmers often use this common
method to disable some code?
I can't answer all these questions, of course (better ask the gcc folks),
but I don't care either. Clearly, none of the above are any reason why
gcc should *not* complain when it sees a _seemingly_ meaningful
condition conceivably written by the programmer with something in
mind but being completely optimized away by it.
[ BTW, perhaps the reason why the gcc folks did *not* put a warning
for while (1) or #if 0 is also because they know that programmers often
write such conditions with something meaningful in mind. ]
> > No, shutting gcc up wouldn't be the right thing, IMHO. These warnings are
> > a good reminder to the programmer to go and see if there is a real bug
> > somewhere and if something really needs to be done with the code (could
> > be simply to change the type of a variable to signed that was mistakenly
> > declared unsigned, f.e.).
>
> OK, but suppose I looked at it and there's no bug. Leaving the
> warning has a cost too: it hides useful warnings (that might be
> showing real bugs) in all the clutter.
Agreed, this warning emits a lot of false positives. But this warning isn't
enabled with -Wall either, or is it (now)? I remember the only way to
enable this was with -Wextra, and last I heard the top-level Makefile
did not specify that ... (?)
Satyam
next prev parent reply other threads:[~2007-05-30 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 8:05 [PATCH] drivers/infiniband: fix comparsion between unsigned and negative Bill Nottingham
2007-05-30 15:30 ` dealing with gcc 'comparison is always false' warnings (was: [PATCH] drivers/infiniband: fix comparsion between unsigned and negative) Roland Dreier
2007-05-30 15:41 ` Satyam Sharma
2007-05-30 15:56 ` [ofa-general] Re: dealing with gcc 'comparison is always false' warnings Roland Dreier
2007-05-30 17:00 ` Satyam Sharma [this message]
2007-05-30 16:06 ` dealing with gcc 'comparison is always false' warnings (was: [PATCH] drivers/infiniband: fix comparsion between unsigned and negative) Satyam Sharma
2007-05-30 19:00 ` dealing with gcc 'comparison is always false' warnings Tilman Schmidt
2007-05-30 19:14 ` Satyam Sharma
2007-05-30 19:09 ` dealing with gcc 'comparison is always false' warnings (was: [PATCH] drivers/infiniband: fix comparsion between unsigned and negative) Bill Nottingham
2007-05-30 19:23 ` Satyam Sharma
2007-05-30 20:48 ` [ofa-general] [PATCH] drivers/infiniband: fix comparsion between unsigned and negative Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0705301000r35e2dde7x8c90ba7b0497e4ef@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®