mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Michael-Luke Jones" <mike.luke.jones@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	dwmw2@infradead.org, "Mark Adler" <madler@alumni.caltech.edu>,
	jloup@gzip.org
Subject: Re: [-mm] Move zlib compression library to common directory [TAKE TWO]
Date: Wed, 30 May 2007 23:35:17 +0530	[thread overview]
Message-ID: <a781481a0705301105n37309182xdf56fb99a3392430@mail.gmail.com> (raw)
In-Reply-To: <465C5549.4050101@gmail.com>

Hi Michael,

On 5/29/07, Michael-Luke Jones <mike.luke.jones@gmail.com> wrote:
>
>
> This patch moves the zlib compression and decompression code
> to a common directory. The zutil.h header, which is not meant
> to be public, is moved from include/linux/ to lib/zlib/.

You could remove the (now pointless) /* WARNING: ... */ comment
from (the now truly private) zutil.h too ...

> In addition, the PRESET_DICT definition from zutil.h, used by
> fs/jffs2/compr_zlib.c is moved to the 'true' public zlib
> header include/linux/zlib.h.

Ugh, I wish you had held on from this patch till the original thread
discussing this reached some conclusion ... from Mark's response
there it does seem PRESET_DICT is clearly an implementation
(and not interface) detail -- which means to me that it must continue
to live in zutil.h (the private header) ... but then, this change is
clearly not so critical either, so it doesn't matter much, I guess.

[ Added zlib authors Mark Adler and Jean-Loup Gailly on this
thread too. ]

Satyam

  parent reply	other threads:[~2007-05-30 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29 14:32 [-mm] Move zlib compression library to common directory Michael-Luke Jones
2007-05-29 16:31 ` [-mm] Move zlib compression library to common directory [TAKE TWO] Michael-Luke Jones
2007-05-30 17:47   ` Andrew Morton
2007-05-30 20:15     ` Michael-Luke Jones
2007-05-30 18:05   ` Satyam Sharma [this message]
2007-05-30 19:20     ` Michael-Luke Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a781481a0705301105n37309182xdf56fb99a3392430@mail.gmail.com \
    --to=satyam.sharma@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=jloup@gzip.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madler@alumni.caltech.edu \
    --cc=mike.luke.jones@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®