From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Keiichi KII" <k-keiichi@bx.jp.nec.com>
Cc: "Matt Mackall" <mpm@selenic.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs
Date: Wed, 13 Jun 2007 21:19:58 +0530 [thread overview]
Message-ID: <a781481a0706130849u2373983eyeab365a8bc90a4dd@mail.gmail.com> (raw)
In-Reply-To: <466FC6BB.4040105@bx.jp.nec.com>
Hi,
On 6/13/07, Keiichi KII <k-keiichi@bx.jp.nec.com> wrote:
> From: Keiichi KII <k-keiichi@bx.jp.nec.com>
>
> This patch contains the following changes.
>
> create a sysfs entry for netconsole in /sys/class/misc.
> This entry has elements related to netconsole as follows.
> You can change configuration of netconsole(writable attributes such as IP
> address, port number and so on) and check current configuration of netconsole.
>
> -+- /sys/class/misc/
> |-+- netconsole/
> |-+- port1/
> | |--- id [r--r--r--] unique port id
> | |--- local_ip [rw-r--r--] source IP to use, writable
> | |--- local_mac [r--r--r--] source MAC address
> | |--- local_port [rw-r--r--] source port number for UDP packets, writable
> | |--- remote_ip [rw-r--r--] port number for logging agent, writable
> | |--- remote_mac [rw-r--r--] MAC address for logging agent, writable
> | ---- remote_port [rw-r--r--] IP address for logging agent, writable
> |--- port2/
> |--- port3/
[...]
> +static int miscdev_configured;
Is this really required? We just return with error if misc_register()
fails during module init time itself, so it's not really useful ever, is it?
> +static ssize_t show_target_attr(struct kobject *kobj,
[...]
> + if (na->show)
> + return na->show(nt, buffer);
> + else
> + return -EIO;
and
> +static ssize_t store_target_attr(struct kobject *kobj,
[...]
> + if (na->store)
> + return na->store(nt, buffer, count);
> + else
> + return -EIO;
EIO isn't quite appropriate for the above two cases. EPERM?
> +static int setup_target_sysfs(struct netconsole_target *nt)
> +{
> + kobject_set_name(&nt->obj, "port%d", nt->id);
Ah, I see, so this is where we use the ->id member.
> @@ -192,7 +386,9 @@ static void cleanup_netconsole(void)
>
> unregister_console(&netconsole);
> list_for_each_entry_safe(nt, tmp, &target_list, list)
> - remove_target(nt);
> + kobject_unregister(&nt->obj);
> + if (miscdev_configured)
> + misc_deregister(&netconsole_miscdev);
Yeah, I suspect we can do away with miscdev_configured here.
We reach this code only if it is known to be true.
> + if (misc_register(&netconsole_miscdev)) {
> + printk(KERN_ERR
> + "netconsole: failed to register misc device for "
> + "name = %s, id = %d\n",
> + netconsole_miscdev.name, netconsole_miscdev.minor);
> + return -EIO;
> + } else
> + miscdev_configured = 1;
> +
Please prefer:
err = misc_register(...);
if (err)
...
return err;
That way we avoid the weird EIO and maintain the error code
returned by misc_register().
Satyam
next prev parent reply other threads:[~2007-06-13 15:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 10:17 [RFC][PATCH -mm take5 0/7] proposal for dynamic configurable netconsole Keiichi KII
2007-06-13 10:25 ` [RFC][PATCH -mm take5 1/7] marking __init Keiichi KII
2007-06-13 14:34 ` Matt Mackall
2007-06-13 10:27 ` [RFC][PATCH -mm take5 2/7] support multiple logging Keiichi KII
2007-06-13 15:30 ` Satyam Sharma
2007-06-13 10:28 ` [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs Keiichi KII
2007-06-13 15:49 ` Satyam Sharma [this message]
2007-06-19 10:03 ` Keiichi KII
2007-06-13 10:29 ` [RFC][PATCH -mm take5 4/7] using symlink for the net_device Keiichi KII
2007-06-13 16:49 ` Satyam Sharma
2007-06-13 19:03 ` Satyam Sharma
2007-06-19 10:04 ` Keiichi KII
2007-06-19 14:40 ` Satyam Sharma
2007-06-21 9:24 ` Keiichi KII
2007-06-19 10:03 ` Keiichi KII
2007-06-19 14:21 ` Satyam Sharma
2007-06-13 10:30 ` [RFC][PATCH -mm take5 5/7] switch function of netpoll Keiichi KII
2007-06-13 17:04 ` Satyam Sharma
2007-06-13 10:31 ` [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target Keiichi KII
2007-06-13 20:41 ` Satyam Sharma
2007-06-19 10:04 ` Keiichi KII
2007-06-19 15:09 ` Satyam Sharma
2007-06-21 9:24 ` Keiichi KII
2007-06-21 10:09 ` Satyam Sharma
2007-06-13 10:31 ` [RFC][PATCH -mm take5 7/7] update documentation Keiichi KII
2007-06-13 17:17 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0706130849u2373983eyeab365a8bc90a4dd@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®