From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Reiner Sailer" <sailer@us.ibm.com>,
"Jesper Juhl" <jesper.juhl@gmail.com>,
kjhall@linux.vnet.ibm.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Seiji Munetoh" <munetoh@jp.ibm.com>,
"Reiner Sailer" <sailer@watson.ibm.com>,
stefanb@us.ibm.com
Subject: Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
Date: Fri, 20 Jul 2007 10:06:13 +0530 [thread overview]
Message-ID: <a781481a0707192136h601bdf0fm14a9a664a7bfa82d@mail.gmail.com> (raw)
In-Reply-To: <86802c440707192120v6b6de39ek811e4f7aed9faa45@mail.gmail.com>
On 7/20/07, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> out_free:
> kfree(log->bios_event_log);
> kfree(log);
> out:
> return err;
>
> could kill one extra goto.
Such constructs disallow the success path from falling through
to the same "return err;" (with err = 0 for success obviously)
next prev parent reply other threads:[~2007-07-20 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 3:33 Reiner Sailer
2007-07-20 4:07 ` Satyam Sharma
2007-07-20 4:20 ` Yinghai Lu
2007-07-20 4:36 ` Satyam Sharma [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-18 23:11 Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0707192136h601bdf0fm14a9a664a7bfa82d@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=kjhall@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=munetoh@jp.ibm.com \
--cc=sailer@us.ibm.com \
--cc=sailer@watson.ibm.com \
--cc=stefanb@us.ibm.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®