From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Rusty Russell" <rusty@rustcorp.com.au>
Cc: "Gabriel C" <nix.or.die@googlemail.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
virtualization@lists.osdl.org
Subject: Re: [PATCH] Make lguest compile with CONFIG_BLOCK=n and CONFIG_NET=n
Date: Mon, 30 Jul 2007 06:18:56 +0530 [thread overview]
Message-ID: <a781481a0707291748x5a70c2d3i83ef54d7f2336b33@mail.gmail.com> (raw)
In-Reply-To: <1185755123.12151.102.camel@localhost.localdomain>
On 7/30/07, Rusty Russell <rusty@rustcorp.com.au> wrote:
> [...]
> Gabriel C reports lguest doesn't compile with CONFIG_BLOCK=n. Fix
> this by introducing a config var for the block device, which depends
> on LGUEST && BLOCK. Do the same for the net driver, rather then
> depending gratuitously on CONFIG_NET.
> [...]
> diff -r 9e987fcabb16 drivers/lguest/Kconfig
> --- a/drivers/lguest/Kconfig Mon Jul 30 09:47:25 2007 +1000
> +++ b/drivers/lguest/Kconfig Mon Jul 30 10:03:39 2007 +1000
> @@ -1,6 +1,6 @@ config LGUEST
> config LGUEST
> tristate "Linux hypervisor example code"
> - depends on X86 && PARAVIRT && NET && EXPERIMENTAL && !X86_PAE
> + depends on X86 && PARAVIRT && EXPERIMENTAL && !X86_PAE
> select LGUEST_GUEST
> select HVC_DRIVER
> ---help---
> @@ -18,3 +18,11 @@ config LGUEST_GUEST
> The guest needs code built-in, even if the host has lguest
> support as a module. The drivers are tiny, so we build them
> in too.
> +
> +config LGUEST_NET
> + tristate
> + depends on LGUEST_GUEST && NET
default y ?
> +
> +config LGUEST_BLOCK
> + tristate
> + depends on LGUEST_GUEST && BLOCK
default y ?
I /think/ the default "y" would also automatically become "m" if any of the
dependencies are modules ... probably need to test this, though.
Satyam
next prev parent reply other threads:[~2007-07-30 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 15:18 [PATCH] BLOCK=n , LGUEST=m/y compile error Gabriel C
2007-07-30 0:25 ` [PATCH] Make lguest compile with CONFIG_BLOCK=n and CONFIG_NET=n Rusty Russell
2007-07-30 0:48 ` Satyam Sharma [this message]
2007-07-30 1:07 ` Rusty Russell
2007-07-30 10:09 ` Gabriel C
2007-07-31 10:11 ` [PATCH] Fix lguest driver config options Rusty Russell
2007-07-30 1:29 ` [PATCH] Make lguest compile with CONFIG_BLOCK=n and CONFIG_NET=n Gabriel C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0707291748x5a70c2d3i83ef54d7f2336b33@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®