From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
mathieu.desnoyers@polymtl.ca, linux-kernel@vger.kernel.org
Subject: Re: 2.6.23-rc4-mm1 build issue: ia64 link error
Date: Sat, 8 Sep 2007 13:20:55 +0530 [thread overview]
Message-ID: <a781481a0709080050g746718a7y3c808c2d4f3c4e73@mail.gmail.com> (raw)
In-Reply-To: <a781481a0709080035h3df2c664x6586ca09c727a096@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
On 9/8/07, Satyam Sharma <satyam.sharma@gmail.com> wrote:
> On 9/7/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > On Fri, 7 Sep 2007 00:34:59 -0700 "Luck, Tony" <tony.luck@intel.com> wrote:
> > > > local symbol 0: discarded in section `.exit.text' from arch/ia64/kernel/built-in.o
> > >
> > > This usually means that there is a static __exit function (or __devexit etc.)
> > > somewhere in the object being linked. The error message is pretty unhelpful
> > > in figuring out *where* in the module. Look at the 'mm' patches that touch
> > > arch/ia64/kernel to see if one of them tinkers with __exit* attributes.
> >
> > Confused. There are >2500 static __exit functions in the tree, including
> > ones like
> >
> > arch/ia64/kernel/esi.c:static void __exit esi_exit (void)
>
> That message means the linker found someone referencing an .exit.text
> function -- on other archs this would've been a section mismatch but on
> ia64 its a link error due to reasons below
> (although it would not have ever caused an oops).
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
In general, there's obviously nothing wrong with ia64's policy of discarding
.exit.text at link time (in fact it's a good optimization), and generally most
references from .init.text (or .text) to .exit.text would really be oopsen.
But not so with this case, because with HOTPLUG_CPU=n (which is when
this link error can occur) it's not possible for the notifier to be
called out in
the first place, and especially not for a CPU_DEAD event, which is when
this reference could've occurred in practice.
Anyway, I came across another little thing while investigating this, patch
attached ...
Satyam
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ia64-perfmon-remove-exit_pfm_fs.patch --]
[-- Type: text/x-diff; name="ia64-perfmon-remove-exit_pfm_fs.patch", Size: 715 bytes --]
[PATCH] ia64 perfmon: Remove exit_pfm_fs()
Because it is dead code and not referenced by anybody else (that file
cannot be built modular).
Signed-off-by: Satyam Sharma <satyam@infradead.org>
---
arch/ia64/kernel/perfmon.c | 7 -------
1 file changed, 7 deletions(-)
--- linux-2.6.23-rc4-mm1/arch/ia64/kernel/perfmon.c~fix 2007-09-08 12:54:24.000000000 +0530
+++ linux-2.6.23-rc4-mm1/arch/ia64/kernel/perfmon.c 2007-09-08 12:54:56.000000000 +0530
@@ -1539,13 +1539,6 @@ init_pfm_fs(void)
return err;
}
-static void __exit
-exit_pfm_fs(void)
-{
- unregister_filesystem(&pfm_fs_type);
- mntput(pfmfs_mnt);
-}
-
static ssize_t
pfm_read(struct file *filp, char __user *buf, size_t size, loff_t *ppos)
{
prev parent reply other threads:[~2007-09-08 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 18:35 Mathieu Desnoyers
2007-09-07 7:34 ` Luck, Tony
2007-09-07 11:01 ` Andrew Morton
2007-09-08 7:35 ` Satyam Sharma
2007-09-08 7:50 ` Satyam Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0709080050g746718a7y3c808c2d4f3c4e73@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®