From: Andrew Lunn <andrew@lunn.ch>
To: Sergey Shtylyov <s.shtylyov@auroraos.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ch9200: return error on failed register writes in ch9200_bind()
Date: Tue, 15 Sep 2026 17:25:37 +0200 [thread overview]
Message-ID: <a7877aed-9454-44a1-a0fa-e4d691a389b8@lunn.ch> (raw)
In-Reply-To: <20260914202503.52920-1-s.shtylyov@auroraos.dev>
On Mon, Sep 14, 2026 at 11:25:02PM +0300, Sergey Shtylyov wrote:
> The successful register writes, done via the USB control requests in
> control_write(), seem vital for the normal functioning of the device,
> however the driver's bind() method ignores error codes returned from
> control_write(). Do bail out of ch9200_bind() on failed writes...
>
> Found by Linux Verification Center (linuxtesting.org) with the Svace
> static analysis tool.
>
> Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-09-15 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 20:25 Sergey Shtylyov
2026-09-14 20:27 ` Sergey Shtylyov
2026-09-15 15:25 ` Andrew Lunn [this message]
2026-09-15 23:20 ` netdev-bot+sashiko
2026-09-16 16:58 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7877aed-9454-44a1-a0fa-e4d691a389b8@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@auroraos.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®