From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Christian Kohlschütter" <christian@kohlschutter.com>,
heiko@sntech.de, lgirdwood@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-rockchip@lists.infradead.org, m.reichl@fivetechno.de,
robin.murphy@arm.com, vincent.legoll@gmail.com, wens@kernel.org
Subject: Re: [PATCH v4] regulator: core: Resolve supply name earlier to prevent double-init
Date: Thu, 25 Aug 2022 16:23:23 +0200 [thread overview]
Message-ID: <a78822d5-f0a1-6c42-8269-e8168ea5cd5b@samsung.com> (raw)
In-Reply-To: <YwdpOX0xCzYwhjmx@sirena.org.uk>
Hi Mark,
On 25.08.2022 14:21, Mark Brown wrote:
> On Thu, Aug 25, 2022 at 01:32:50PM +0200, Marek Szyprowski wrote:
>
>> This patch landed recently in linux next as commit 8a866d527ac0
>> ("regulator: core: Resolve supply name earlier to prevent double-init").
>> Unfortunately it breaks booting of Samsung Exynos 5800 based Peach-Pi
>> (arch/arm/boot/dts/exynos5800-peach-pi.dts) and Peach-Pit
>> (arch/arm/boot/dts/exynos5420-peach-pit.dts) Chromebooks. The last
>> message in the kernel log is a message about disabling 'vdd_1v2'
>> regulator. This regulator is not used directly, however it is a supply
>> for other critical regulators.
> This suggests that supplies are ending up not getting bound. Could you
> perhaps add logging to check that we're attempting to resolve the supply
> (in the
>
>
> + if ((rdev->supply_name && !rdev->supply) &&
> + (rdev->constraints->always_on ||
> + rdev->constraints->boot_on)) {
>
> block)?
I've spent a little time debugging this issue and here are my findings.
The problem is during the 'vdd_mif' regulator registration. It has one
supply called 'inb1' and provided by 'vdd_1v2' regulator. Both 'vdd_mif'
and 'vdd_1v2' regulators are provided by the same PMIC.
The problem is that 'inb1' supply is being routed to dummy regulator
after this change. The regulator_resolve_supply(), which is just after
the above mentioned check, returns 0 and bounds 'vdd_mif' supply to
dummy-regulator. This happens because regulator_dev_lookup() called in
regulator_resolve_supply() returns -19, what in turn lets the code to
use dummy-regulator. I didn't check why it doesn't return -EPROBE_DEFER
in that case yet.
> I'd also note that it's useful to paste the actual error
> messages you're seeing rather than just a description of them.
There is really nothing more that I can paste here:
[ 32.306264] systemd-logind[1375]: New seat seat0.
[ 32.331790] systemd-logind[1375]: Watching system buttons on
/dev/input/event1 (gpio-keys)
[ 32.550686] systemd-logind[1375]: Watching system buttons on
/dev/input/event0 (cros_ec)
[ 32.570493] systemd-logind[1375]: Failed to start user service,
ignoring: Unknown unit: user@0.service
[ 32.750913] systemd-logind[1375]: New session c1 of user root.
[ 35.070357] vdd_1v2:
--- EOF ---
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2022-08-25 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:33 [PATCH v2] " Vincent Legoll
2022-08-04 10:44 ` [PATCH v3] " Christian Kohlschütter
2022-08-15 11:17 ` Mark Brown
2022-08-18 12:46 ` [PATCH v4] " Christian Kohlschütter
[not found] ` <CGME20220825113251eucas1p247c3d57de823da148ca4790975a4aba8@eucas1p2.samsung.com>
2022-08-25 11:32 ` Marek Szyprowski
2022-08-25 12:21 ` Mark Brown
2022-08-25 14:23 ` Marek Szyprowski [this message]
2022-08-25 15:18 ` Christian Kohlschütter
2022-08-25 21:28 ` [PATCH v5] " Christian Kohlschütter
2022-08-25 21:35 ` Christian Kohlschütter
2022-08-26 5:55 ` Marek Szyprowski
2022-08-29 15:43 ` Mark Brown
2022-08-29 17:01 ` Christian Kohlschütter
2023-02-17 23:22 ` Saravana Kannan
2023-02-17 23:33 ` Christian Kohlschütter
2023-02-17 23:46 ` Saravana Kannan
2023-02-18 0:01 ` Christian Kohlschütter
2023-02-18 0:05 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78822d5-f0a1-6c42-8269-e8168ea5cd5b@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=broonie@kernel.org \
--cc=christian@kohlschutter.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=robin.murphy@arm.com \
--cc=vincent.legoll@gmail.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®