From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751611AbdCPId2 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 04:33:28 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:33732 "EHLO
        mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751055AbdCPIdX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 04:33:23 -0400
X-AuditID: cbfec7f2-f790f6d000002555-4e-58ca4b3a1b08
Subject: Re: [PATCH v2 2/3] Input: add support for the STMicroelectronics
 FingerTip touchscreen
To: Andi Shyti <andi.shyti@samsung.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        Andi Shyti <andi@etezian.org>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <a78e77c3-7bc5-95a8-fbf9-31baf91cdd56@samsung.com>
Date: Thu, 16 Mar 2017 09:22:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.7.0
MIME-version: 1.0
In-reply-to: <20170210021721.12218-3-andi.shyti@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGeXd2zi42O06zf5aNhkoJmaHUwcRS+rCKSiVo9UUPelLJqe2o
        aH4xKdMpKd6bhpLXlmFsanZR88JcSpmWV0rti1ZoyZZpWSO3Y+C33///Pg/P+7y8Qkyqw92E
        cQnJjDqBjpcTYn678dfwwYAzg0pfY6WEetI/j1O1aws8auLHAk5V97/Bqb77nxG1uNTMo4aH
        HwuoKfNPnHr3rIqgKoa7eNStzn7BCQfFRJ0ZUzzVfhQo9LpcQtFasEF3WnVIYdHvDSUuiwOj
        mfi4VEZ9KChSHKtvn+AnjRJpk13T/EyUh2uQSAikP/weySY4doW3My12lpL1CD7VXNEg8QZb
        EDQ9MiMNEtoNi7cRt29AYFmfwblhHkFDZRdhEzmTNFQXJdn2LuQfBG2mWbsDI6sRaL/fxGwR
        BHkA/hqm7HESMgjmslp4NuaTnjDWNmbX7CCV0DGZv6lxgrXiGb6NRWQgGCZu2PcY6QsVJX08
        jmVgaF7CbGFAjgrg9XgpwV3bHfQvMa7mSWgss/I5doavA60CjvdAbk4Pj/PmITAXmATcUILA
        ulyx6T4GfQMjOJfmCEXt5RgXIIGcbCknUUDb8/rNgGDIzyoTcG/ag+BLmWMhkmm39NFu6aDd
        0qEGYTrkwqSwqhiG9fNhaRWbkhDjE5Wo0qONHzRkHTB3oBVTQC8ihUi+TVJ49pVSitOpbLqq
        F4EQk7tI5hwGlVJJNJ1+nVEnRqhT4hm2F+0W8uU7JS9q3l+UkjF0MnOVYZIY9f9TnlDklonS
        w5tqG5Y9E9NOs+5HI0WBYQEy9YDriowOiVpfNR4PZSw1Ii//2XDyrClsn+GU3+oRp2mgq0q/
        xQef766zeOPdrgsfrnls793/UGQsrw8djSWGqu+N97daL3nEZGaW6VKi8NkK55mMxuxdD855
        hWTkX+g0aIqT70bEhbdBl7ucz8bSh70xNUv/A48TFEs9AwAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t/xq7oLvE9FGDTNFrTYfuQZq8XiH8+Z
        LK5/ec5qMf/IOVaLw4teMFq8ebuGyeL8+Q3sFjc/fWO1uLxrDpvFjPP7mCxa9x5hd+D2uL7k
        E7PHzll32T02repk89jSD2T1bVnF6PF5k1wAW5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWS
        Ql5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMjZtu85ScImt4sa+WywNjN2sXYwc
        HBICJhJv2hm7GDmBTDGJC/fWs3UxcnEICSxhlLj7eiEzhPOMUaKv/QcLSIOwQKLE/EkFIHER
        gX+MEt9+X2GFKDrIKHF5+hwWEIdZYD6jxNz9a9hA5rIJaEr83XwTzOYVsJN40LSeCcRmEVCV
        uLr1KjOILSoQITH/6SomiBpBiR+T77GA2JwCNhKbrzeygWxmFtCTuH9RCyTMLCAvsXnNW+YJ
        jAKzkHTMQqiahaRqASPzKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMBo3Hbs5+YdjJc2Bh9i
        FOBgVOLhneB7MkKINbGsuDL3EKMEB7OSCO8D7lMRQrwpiZVVqUX58UWlOanFhxhNgV6YyCwl
        mpwPTBR5JfGGJobmloZGxhYW5kZGSuK8JR+uhAsJpCeWpGanphakFsH0MXFwSjUw5p4wbH71
        8rDgdv+pXIURM88s2FDKYfFn/Y4FXHOCTzQKfQp9wX/k8KLJQW+2hofKCZxb/HrfjShJ3ccb
        g3X1ggVtL6V/dxR67/plUcf9N62Xf6wI2lEd92bPmuQrn50FA+ZOie5/pZy31f+OQ+Li/7Wu
        U9f02DDVna5iU/z0ekuteq9CoWRbiBJLcUaioRZzUXEiAAqMbeHcAgAA
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170316082217eucas1p155fd1eb108cd1c50fb077ced5af56e86
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.179
X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?=
        =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?=
        =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 201P
X-HopCount: 7
X-CMS-RootMailID: 20170210021729epcas1p3e11cade2daa21d2dd23839975e29acb6
X-RootMTR: 20170210021729epcas1p3e11cade2daa21d2dd23839975e29acb6
References: <20170210021721.12218-1-andi.shyti@samsung.com>
 <CGME20170210021729epcas1p3e11cade2daa21d2dd23839975e29acb6@epcas1p3.samsung.com>
 <20170210021721.12218-3-andi.shyti@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andi,

On 10.02.2017 03:17, Andi Shyti wrote:
(...)
> +
> +	err = devm_request_threaded_irq(&client->dev, client->irq,
> +					NULL, stmfts_irq_handler,
> +					IRQF_ONESHOT | IRQF_TRIGGER_LOW,
> +					"stmfts_irq", sdata);
> +	if (err)
> +		return err;
> +
> +	/*
> +	 * Disable irq they, they are not needed at this stage.
> +	 * One possible case when an IRQ can be already rased is e.g. if the
> +	 * regulator is set as always on and the stmfts device sends an IRQ as
> +	 * soon as it gets powered, de-synchronizing the power on sequence.
> +	 * During power on, the device will be reset and all the initialization
> +	 * IRQ will be resent.
> +	 */
> +	disable_irq(sdata->client->irq);

It is safer to set:
    irq_set_status_flags(client->irq, IRQ_NOAUTOEN);
before devm_request_threaded_irq

Regards
Andrzej