From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F7CF3D566C for ; Wed, 11 Mar 2026 11:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230237; cv=none; b=XKWgWCd61Ll8+x/pCLvblHpAvq60s/waJzouQ3FwyNGVJSY9dZCFVBDkF3emeuvkIScmeR835250cKtsjCli9dbIW4HWCUa+6l+e61IvMfeSDfVV0cq3Ni2mnrBJ3Sxi3MdF8qeDnEwJGBWo4cx9wHTSMC0aqMWC+iBsUBG2t20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230237; c=relaxed/simple; bh=zqt1TJo6M5ytVgoiQO4PNEkMGsD06msQOJ67zLe/YZQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=i5IOUkvK2mYgmJNdpsyvZr7tgmqxoy1qt11qphdzjZiFo9AW25DAcLXY9FgiKCp6I+F3ZQsuz/urS+NBxI1Ag1huJU71nLB1ncOiALUz0yF+z8cVkETc4JR/QqrHNJuTPrvi7eEh2vN3p1y7nAClntz7mAKC9a/Al+JCcDDqxEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SUz3g2Ju; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SUz3g2Ju" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4853f2826f7so31072355e9.1 for ; Wed, 11 Mar 2026 04:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773230233; x=1773835033; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zqt1TJo6M5ytVgoiQO4PNEkMGsD06msQOJ67zLe/YZQ=; b=SUz3g2JuSj0UmQYfQ/A0s/awEkP9EdpgvhQLowuko5kEM5/Slvj1nvL3Q9ELk3EMVg oZN773twe147kv2CTAmGXNnqkBhSk4Auvu0TISOdj0PAoLrBdEwpF4apQ1LSnvxTSDOM 7GHbrp15fjBnAFwQqOP20qeTFRhjrC6pzp0t1sl9SLbWt7kAIvQ44T6xhGlzfL6gFkie p+NZuCOf+lAGx3P50QrTg+6epXqClY+Z5U1INaCsI5ZTZaL1EPg8OR7K4cT1XtUKfheS AudaosZG9M8ESGBW8fjnyXEhnXhy6CduMTxara3s10NwI7NRCgMc821iUAqnasn8Rqqo WflQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773230233; x=1773835033; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zqt1TJo6M5ytVgoiQO4PNEkMGsD06msQOJ67zLe/YZQ=; b=PzH+hsZMoEXGUokeTT5xM3/SncdMNoYhlq+NQZ9WAg7riSdW2N1xXeL4bzqY+tcyHc Rn1ZCd1+Ght4LQP8hdJtzWYAontE9jUdo2BlgOY6P5LA0e96b4JUDJddOYGp9DjdSLwE 9VYGyOSyUCIvdZLULrAM0TqFR0okJfPOn+Ue+PoSje+bIutVef0DRJ/9mHqFeukRAxPY vICOvTS8VsYSRO1sxJq3aMbry7MneM1Llcw49Pjzy6k8eMknWX/ktIUnrr2bYmGFSLZv 8y3AildOIF9WlN0CWBUyqW/OLWh2QLCpaWzEDiFhJs/k9XL/78fhQV6MuNFzTFtypdHY 1VgA== X-Forwarded-Encrypted: i=1; AJvYcCV6k0Kgb+9LPJVFleN32IcbUaZT+ohnZxyLHSrmnpgj1/HaAq42Wur5xwlm2LLKp/1+c5aYNG5iyUKk7Gc=@vger.kernel.org X-Gm-Message-State: AOJu0YwiIYbi8vPJbGlk8udVusXNvbv5RBsgp3mm3ZzKml46Sx7zmOxW 26AFxUvBMEtmWaTnoUAXjjLscXOrvlpjNOOQo8BHse+ezFogZO9ALs9B X-Gm-Gg: ATEYQzxTSb31uKTb9r7TYV72Ix3ToCsLiVIcJ61iTP45KQzWweH5Rm9A0PHYwp1q3ZO UnHVObPP2bo81vBnb2/Uhazvt2HaCFqxx91L99nYHGXdlQudxhLiPJfnpjt22XAaNEJicpMuDMu iBnaR8OCeOExQQghgXhJaz0QwanKU+fyVV1crLaO4KuCIhFVRdDVDt9nXa8Y5xTuPMJ4ghGd9op o8pqWkfz408a8Fg2YoHNUSiAVPExoBVOlYBl8m5RZuiaChbYr3PXcRyzRZfMdYWwadF14EQLi0Z y9p+d8zuDCb6fuAqTDp49R/MrA26hgHqIVmjxPfdp8/TsNJTx8GQY464a3LOElcx5pSfaR7MzXc 7zR3pQNvWGb/Bu/VxkOCdYblyZ+mB4rGzfJFGDWDSQlw1t416S692cruJmmrNAPrl3g/6YcxL32 +NNh+Dg+dbpWQyEt7oj7Lilvt3+JFzow8= X-Received: by 2002:a05:600c:138a:b0:485:40c6:f507 with SMTP id 5b1f17b1804b1-4854b136ac7mr38643825e9.30.1773230232448; Wed, 11 Mar 2026 04:57:12 -0700 (PDT) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b0d4977sm17543575e9.19.2026.03.11.04.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 04:57:12 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios From: Nuno =?ISO-8859-1?Q?S=E1?= To: Taha Ed-Dafili <0rayn.dev@gmail.com>, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Date: Wed, 11 Mar 2026 11:57:56 +0000 In-Reply-To: <20260310174835.24209-2-0rayn.dev@gmail.com> References: <20260310174835.24209-1-0rayn.dev@gmail.com> <20260310174835.24209-2-0rayn.dev@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-10 at 17:48 +0000, Taha Ed-Dafili wrote: > The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin. >=20 > Use standard output-range-microvolt and range-sel-gpios properties to > describe the hardware configuration of the R_SEL pin. Ensure mutual > exclusivity using the not/required logic. Additionally, add missing > vlogic-supply, clear-gpios, ldac-gpios and datasheet links, and provide > a complete usage example. >=20 > Suggested-by: David Lechner > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> > --- > =C2=A0.../bindings/iio/dac/adi,ad5504.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 40 ++++++++++++++++++- > =C2=A01 file changed, 39 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml > b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml > index 9c2c038683b4..c0b2d470949a 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml > @@ -10,8 +10,10 @@ maintainers: > =C2=A0=C2=A0 - Lars-Peter Clausen > =C2=A0=C2=A0 - Jonathan Cameron > =C2=A0 > -description: > +description: | > =C2=A0=C2=A0 High voltage (up to 60V) DACs with temperature sensor alarm = function > +=C2=A0 https://www.analog.com/media/en/technical-documentation/data-shee= ts/ad5504.pdf > +=C2=A0 https://www.analog.com/media/en/technical-documentation/data-shee= ts/ad5501.pdf > =C2=A0 > =C2=A0properties: > =C2=A0=C2=A0 compatible: > @@ -27,16 +29,48 @@ properties: > =C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 1 > =C2=A0 > =C2=A0=C2=A0 vcc-supply: true > +=C2=A0 vlogic-supply: true > + > +=C2=A0 output-range-microvolt: > +=C2=A0=C2=A0=C2=A0 description: | > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Specify the channel output full scale ran= ge. The R_SEL pin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 determines if the range is 0-30V or 0-60V= . > +=C2=A0=C2=A0=C2=A0 items: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: 0 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - enum: [30000000, 60000000] > +=C2=A0=C2=A0=C2=A0 default: [0, 60000000] > + > +=C2=A0 range-sel-gpios: > +=C2=A0=C2=A0=C2=A0 description: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPIO connected to the R_SEL pin to select= the output voltage range. > +=C2=A0=C2=A0=C2=A0 maxItems: 1 > + > +=C2=A0 clear-gpios: I would match the datasheet name. So clr. - Nuno S=C3=A1 > +=C2=A0=C2=A0=C2=A0 description: GPIO that controls the /CLR pin (active = low). > +=C2=A0=C2=A0=C2=A0 maxItems: 1 > + > +=C2=A0 ldac-gpios: > +=C2=A0=C2=A0=C2=A0 description: GPIO that controls the /LDAC pin (active= low). > +=C2=A0=C2=A0=C2=A0 maxItems: 1 > =C2=A0 > =C2=A0additionalProperties: false > =C2=A0 > =C2=A0required: > =C2=A0=C2=A0 - compatible > =C2=A0=C2=A0 - reg > +=C2=A0 - vcc-supply > + > +allOf: > +=C2=A0 - not: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - range-sel-gpios > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - output-range-microvolt > =C2=A0 > =C2=A0examples: > =C2=A0=C2=A0 - | > =C2=A0=C2=A0=C2=A0=C2=A0 #include > +=C2=A0=C2=A0=C2=A0 #include > + > =C2=A0=C2=A0=C2=A0=C2=A0 spi { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #address-cells =3D <1>; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #size-cells =3D <0>; > @@ -45,6 +79,10 @@ examples: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = compatible =3D "adi,ad5504"; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = vcc-supply =3D <&dac_vcc>; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = interrupts =3D <55 IRQ_TYPE_EDGE_FALLING>; > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 outpu= t-range-microvolt =3D <0 60000000>; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clear= -gpios =3D <&gpio 4 GPIO_ACTIVE_LOW>; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ldac-= gpios =3D <&gpio 5 GPIO_ACTIVE_LOW>; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; > =C2=A0=C2=A0=C2=A0=C2=A0 }; > =C2=A0...