From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DDD3D88E1 for ; Fri, 12 Jun 2026 06:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781246595; cv=none; b=ueqQn6NhrdtO0P4iwYHIzqnhJCbCcfrY/Gi/+/h4bBygjVqnn+71SsZE+QCXEf8/eOtY2sRvhlvWQqNBIFKrCsMHLJXZ0mERWm/9HLXIP73x65SLm5bYmSd2RIxGWTi4WTi5zOUkdJuG5NtrehTWvrVbgHUXhhuc7fxM6vgl0nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781246595; c=relaxed/simple; bh=fj2BDTolpIHjrNcpJ4WVAWJObJAgy1V02X3sJ8SSQQw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aAwtOtQ8hpqYGwrh9uxQGnDjuOQ1w6u3aSeExRY3C69BBWG0IMGwu4jf6P/YFhokt9Iu/z8J7p1cfoRKp9gCV6sT19tEFNxzDne5OEFdKGxFEgEcL8i7Mx5wn1CXMI2ODCvgxvIy3ty6KeSXjWGpEH8vHTMXqbJpgiwE3tmw3ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XtH2M7oW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aAJhW3KD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XtH2M7oW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aAJhW3KD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65C3Bp9I2401891 for ; Fri, 12 Jun 2026 06:43:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xhRQQ0HqfVlogSV46vuX6Ct/PmcPgUZ4ULZ4DIlTmCI=; b=XtH2M7oW9JPOsZWJ iHfSpi9vnqUy5YGyEGCXw3UU6IzJljTcb4CeJSnQmLl1IYfbE9sCanXF0/bxt/lE QZbEuCUXXxPCwUO2Tf1d/1moLY0MqDS/eGOOmSZvEehMkX526kmyZFIKOqeFor0J kyvyH/6THMVBvBbVwqc7uXNDY89ULDzrS69jE2eu8DDiUunX56UiChP3S/2MJrfd IQxMIwZHyH2D01w9b2S/c16DreByhIGSlTHnwf0OUbm8fHKxrwsEKrGOay0CGvSu oqHcJTDteHCzvQBYWD/a/ZAloBPiw0hateVQxEjzK3xx5yGRw5lhX8oz7qWnl1wa KRY/BA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er30g9vh2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 06:43:12 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36d98b74447so598117a91.2 for ; Thu, 11 Jun 2026 23:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781246592; x=1781851392; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xhRQQ0HqfVlogSV46vuX6Ct/PmcPgUZ4ULZ4DIlTmCI=; b=aAJhW3KDulO3rQsYsa9fvw6c0kXxAbXCizjHJfLqgfkZjZixgfvL9+ckZEVkswK5Oh EAKeXMWwX87Zv0TqOW335ayribprOazJ0n23/FqmrRuhiD5oYduS4qJDj7IirDIsBgiJ jUEGci3bGjwM/jppHRZtvcAR9805XQcGrkcS0PadoR6tY+uarvUZwSAMQBoU5sVCFGwK TYh4hQBcVQBjnx3Qk1yy6g3/VN3DCm2nr0Fjr7CC8ywXXyALMLPzkTNoKRSVkqt7S0y4 iawjmvIT7zPDp89aAamWDq7LLDJEywJ1cFkOO/5ffjjD9pctOFX6+Jw3TrE7m2ab6g4z Dm1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781246592; x=1781851392; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xhRQQ0HqfVlogSV46vuX6Ct/PmcPgUZ4ULZ4DIlTmCI=; b=qtAB1hLMqfB0eyYusK7NhzydNrQB9uqGGl9fxJUvWg5jeqXxPatRzzNtA+ffEPFbIn lSYMOMAhcjaebun+tJvXJ7Z4ywLoSU1C3+UI5jb37IFdJwdnml6orCj1kLBnMGzM1+dU RzSnC/adL0oXK7vswBH6vDpLMHUxtOafvKMzs3OgqX2LJ5o/1O50GUccZZxqpeS3pDwv 6bOsj+teja9uOy8EWQ4NQ8aUQGp3tzLh9SHfg/d1MlwkpAmf9sOHYpZ3gzt2a7DWkIeK C7O2TZmZ8dPlhMuo9TZXsJ46mjq7JKmWkWr5ciMJne5rNWn3R3k8J2tnPgzY/EPyzpvY P3MQ== X-Forwarded-Encrypted: i=1; AFNElJ9cGVjf6iomR9oIZdGXW0gGNtmuNusAbsBge0QcB4na8h4VmPGae5EodAUYkpG1jy7q+UYI+WFiHABj07c=@vger.kernel.org X-Gm-Message-State: AOJu0YznAs8Vsah+kBHGGsa9llXvG6ZHGSVqodtfj1m4TfVQWfTOs0Tf 2n3R3QVuvgfOMITgSHWG32/5aQaseRWXS26ZBeaDafXhMC6cm7pbY7y7OhCcgErEMnRpz8mKXGB OpHGrqH9OSSOZzv42s3n/dmQiUSWw4w7xTAyG0SYCNmUeJLrZnRSqE+JE8YRjAvblBqg= X-Gm-Gg: Acq92OH/imIk+vSlO1FA9Dbgn6yl7XVSeuw4Yau8nAYqWWRQh6is2amvoK2YWate/wB aIuzbikm9l3myYk4qhHJNJ1ZlAX1RbKJr3eqjcUY5U3zQvNgYYGItJjBWXL93fQq5erP/YvROH/ 9SDzDfleS9Xc9fgwE063bBtiO26URY3V9Po8c+DXeiaOjy1eDX8kMJGYexhkrgNeZ8Xz6PmihBJ YWRERr/U+tYY102rNnUx+sbvgNh4UVzgiqgy6TcbEDGzz3Odqg1OGTnTl5h+7J1NaS8VoSakJv2 +y5X5sCSjKfW44xKOR74SGmdpppJZToIP+a0IwIWfgs7qTVaFO2oTXL86OsqDozhl+eZLIMv9IV 5DZYpgoSLUj0yYPkLRKy0gir52yYMFtH9u/LdS428l6/yqaRE6WwbLHw4rHC2cLY= X-Received: by 2002:a17:903:32c6:b0:2bf:1486:e6ca with SMTP id d9443c01a7336-2c41050947bmr19439315ad.12.1781246591663; Thu, 11 Jun 2026 23:43:11 -0700 (PDT) X-Received: by 2002:a17:903:32c6:b0:2bf:1486:e6ca with SMTP id d9443c01a7336-2c41050947bmr19439015ad.12.1781246591074; Thu, 11 Jun 2026 23:43:11 -0700 (PDT) Received: from [192.168.1.8] ([122.164.81.0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f7c6c5dsm9266445ad.21.2026.06.11.23.43.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 23:43:09 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 12:13:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add IPQ9650 PCIe PHY support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260602-ipq9650_pcie_phy-v1-0-d8c32a36dbd9@oss.qualcomm.com> <20260602-ipq9650_pcie_phy-v1-2-d8c32a36dbd9@oss.qualcomm.com> <56zkq7bwrt5smmmum6jckzrekkkqrych2gntx3obnrmamwumtv@espahwe6pc3v> <7def2ccd-0319-4f85-8275-73fd254d887d@oss.qualcomm.com> <602e893c-d346-486d-86b3-50d0f01990bf@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDA1OSBTYWx0ZWRfX0rZcozm4+JbU 81DAN3RfnP+4N3LpGmSFV2P4cMrZBBmsvJZGlbyECZIsdTMjzokIqwFaIi61XbpMVPC/EgbRO5Z jpwY9xi1Rj03u8lVYTJvklSnEG3M598= X-Proofpoint-GUID: av5xiIKDite9V1KGuuzgRjhuBHlPFFLd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDA1OSBTYWx0ZWRfX0LFvMZkpFfYr 6YN4RHJPxfB9gX0fCjP1sRD7/DsBjJMz12dmmqs1+l4kaV6X51BuPmB9bbY1B5KxrvHKlik2tPz Td79SESNZDefVK1qE1NXqqB5k2j27Ws7FnQLwBwLZHMPNaA7ak9B9oPQ74lzMdre4uskMloaTqI RIdcvfSo2is9Dp875st81G524JRWzPsvlxnA9yCNliqEvSbia50q+1efRfbfjIhTiwIzdEI9yYV /IzkjVIicR7Fwk7/m9ZvOiovEVPzrSljmbPSUxST3mLW8/+8cckbfdFKj0F0SNRSTn4dlORiG9k 64KP/VEK4QNag4L8XFBskDVxA13mQOWGxB//vgg3dB8ktJmK9CMqU3ZtCeD16L+k99bfrz0Dcf8 Srmp3xmEjv2anz+61FCMhh9Tzjzg0Yu4yGmtW9QCzC0NVH1dKnER9xLrOWnqFyhp3ymf0Jmg2Il OfD92OKmkZaedjRXI6g== X-Authority-Analysis: v=2.4 cv=evnvCIpX c=1 sm=1 tr=0 ts=6a2baa80 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=DVNErGSwdtF8OHn2hLoakQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=JfrnYn6hAAAA:8 a=EUspDBNiAAAA:8 a=hfAPQjwllD3DkVB7DTwA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-ORIG-GUID: av5xiIKDite9V1KGuuzgRjhuBHlPFFLd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_01,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120059 On 6/12/2026 11:44 AM, Dmitry Baryshkov wrote: > On Fri, Jun 12, 2026 at 08:22:02AM +0530, Kathiravan Thirumoorthy wrote: >> On 6/12/2026 1:52 AM, Dmitry Baryshkov wrote: >>> On Tue, Jun 09, 2026 at 03:46:56PM +0530, Kathiravan Thirumoorthy wrote: >>>> On 6/8/2026 12:26 PM, Dmitry Baryshkov wrote: >>>>> On Tue, Jun 02, 2026 at 02:40:18PM +0530, Kathiravan Thirumoorthy wrote: >>>>>> The IPQ9650 platform has three Gen3 2-lane PCIe controllers and two Gen3 >>>>>> 1-lane PCIe controllers. The PHY instances also require the on-chip refgen >>>>>> supply. >>>>>> >>>>>> Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations, including the >>>>>> refgen regulator supply. >>>>>> >>>>>> Signed-off-by: Kathiravan Thirumoorthy >>>>>> --- >>>>>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 220 +++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 220 insertions(+) >>>>>> >>>>>> @@ -3378,6 +3524,10 @@ static const char * const qmp_phy_vreg_l[] = { >>>>>> "vdda-phy", "vdda-pll", >>>>>> }; >>>>>> +static const char * const ipq9650_qmp_phy_vreg_l[] = { >>>>>> + "refgen", >>>>>> +}; >>>>> Now vdda-phy / vdda-pll supplies? >>>> Cross checked with HW team again. Along with refgen, there is a on-chip LDO >>>> which supplies fixed voltage to the PHYs. It is enabled upon system power on >>>> and no SW intervention is required. >>> What is it being powered by? MX? CX? >> It is driven by CX. > I assume that there is no CX collapse on IPQ9650? Is CX not scaling on > this chip. Please provide some details on the commit message. That's right. No CX collapse on IPQ9650. Let me rewrite the commit message as below. Hope its okay. -- Add support for the IPQ9650 platform, which includes three Gen3 x2 PCIe controllers and two Gen3 x1 PCIe controllers. The PHY instances require the on-chip refgen supply. Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations along with the refgen regulator supply. Note that an on-chip LDO, driven by the SoC CX, supplies the PHY voltages without requiring software control. Note that CX power collapse is not supported on IPQ9650. -- > >>>> regulator-fixed doesn't take the resource 'reg'. May be should I create >>>> another regulator driver which accepts 'reg', something similar to the >>>> qcom-refgen-regulator? Please advise. >>> If it doesn't require control, there is no need for a separate driver or >>> separate supply. For example, the refgen is being references only by >>> those devices which require software votes. >> Thanks. Then let me respin this series on top of phy-next so that Vinod can >> pick it up. >> >>>>>> + >>>>>> static const char * const sm8550_qmp_phy_vreg_l[] = { >>>>>> "vdda-phy", "vdda-pll", "vdda-qref", >>>>>> }; >> -- >> linux-phy mailing list >> linux-phy@lists.infradead.org >> https://lists.infradead.org/mailman/listinfo/linux-phy