From: Dave Hansen <dave.hansen@intel.com>
To: "Li,Rongqing(ACG CCN)" <lirongqing@baidu.com>,
"Huang, Kai" <kai.huang@intel.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 答复: [外部邮件] Re: [PATCH] x86/sgx: Fix SRCU list traversal
Date: Mon, 23 Feb 2026 17:14:34 -0800 [thread overview]
Message-ID: <a79e6300-4188-4670-b801-0f64bcffb673@intel.com> (raw)
In-Reply-To: <488bbc6d03eb4a8ebba1a7ff1b89f852@baidu.com>
On 2/23/26 16:30, Li,Rongqing(ACG CCN) wrote:
>>> Replace list_for_each_entry_rcu() with list_for_each_entry_srcu() when
>>> traversing the encl->mm_list protected by SRCU. This ensures proper
>>> synchronization annotation and avoids potential lockdep warnings about
>>> incorrect RCU usage.
>>>
>>> The list is protected by encl->srcu, not RCU, so the SRCU-specific
>>> iterator with srcu_read_lock_held() annotation is required.
>>>
>>> Signed-off-by: Li RongQing <lirongqing@baidu.com>
>> Acked-by: Kai Huang <kai.huang@intel.com>
> Thanks for reviewing , and ping
It's a light NAK from me with the current changelog.
I want a wee bit more background and some reasoning _somewhere_ about
why this wasn't a bug when the code went in originally but arguably
became a buglet at some point.
next prev parent reply other threads:[~2026-02-24 1:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 1:53 lirongqing
2026-02-05 17:58 ` Dave Hansen
2026-02-05 21:15 ` 答复: [外部邮件] " Li,Rongqing
2026-02-11 10:38 ` Huang, Kai
2026-02-24 0:30 ` 答复: [外部邮件] " Li,Rongqing(ACG CCN)
2026-02-24 1:14 ` Dave Hansen [this message]
2026-02-24 2:51 ` 答复: " Li,Rongqing(ACG CCN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79e6300-4188-4670-b801-0f64bcffb673@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome