From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>, Chia-I Wu <olvaffe@gmail.com>,
Matthew Brost <matthew.brost@intel.com>,
kernel-dev@igalia.com, linux-kernel@vger.kernel.org,
Bradley Morgan <include@grrlz.net>, Chia-I Wu <olv@google.com>,
Breno Leitao <leitao@debian.org>
Subject: Re: [RFC v4 1/2] workqueue: Add support for real-time workers
Date: Tue, 08 Sep 2026 12:51:23 -1000 [thread overview]
Message-ID: <a7ac8aee6a315d4d6465b728d1d28226@kernel.org> (raw)
In-Reply-To: <8b0ea995-8299-4f68-9c06-2350a1d8fa2e@igalia.com>
Hello,
On Mon, Sep 07, 2026 at 04:00:47PM +0100, Tvrtko Ursulin wrote:
> I thought it was more elegant to split the policy from the priority
> within a policy for call sites which only look up the policy.
I'd prefer a single priority value. NORMAL and HIGH use the same policy, and
nice already determines their priority. With both fields in the pool
attributes, otherwise identical unbound queues with the same nice level
cannot share a pool if one is NORMAL and the other HIGH. rt_prio() can keep
the RT checks simple.
> I did not quite manage to follow you here. Was this not the per cpu
> part, with unbound and ordered down lower?
Yes, I was confused. Please disregard that comment.
> I suppose this landed by now? I can see some changes so once we clarify
> the above opens I will rebase and adjust.
The shared allocation path is in wq/for-7.4 now. Please rebase on that.
Per-cpu pools are still separate, but RT can remain unbound-only without
waiting for the rest of the unification. Converting the shared priority
field still needs the corresponding updates to per-cpu/BH initialization and
priority checks.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-09-08 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:19 [RFC v4 0/2] Realtime workqueues and panthor realtime submission Tvrtko Ursulin
2026-08-04 10:19 ` [RFC v4 1/2] workqueue: Add support for real-time workers Tvrtko Ursulin
2026-08-16 19:10 ` Tejun Heo
2026-09-07 15:00 ` Tvrtko Ursulin
2026-09-08 22:51 ` Tejun Heo [this message]
2026-08-16 20:29 ` Bradley Morgan
2026-08-04 10:19 ` [RFC v4 2/2] drm/panthor: Create per queue priority workqueues Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ac8aee6a315d4d6465b728d1d28226@kernel.org \
--to=tj@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=include@grrlz.net \
--cc=kernel-dev@igalia.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=matthew.brost@intel.com \
--cc=olv@google.com \
--cc=olvaffe@gmail.com \
--cc=steven.price@arm.com \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®