From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Lizhi Hou <lizhi.hou@amd.com>, <ogabbay@kernel.org>,
<dri-devel@lists.freedesktop.org>
Cc: <linux-kernel@vger.kernel.org>, <min.ma@amd.com>,
<max.zhen@amd.com>, <sonal.santan@amd.com>, <king.tam@amd.com>,
<mario.limonciello@amd.com>, Mike Lothian <mike@fireburn.co.uk>
Subject: Re: [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c
Date: Fri, 13 Dec 2024 09:20:37 -0700 [thread overview]
Message-ID: <a7add90f-3d78-9ced-655f-a1918fb04af3@quicinc.com> (raw)
In-Reply-To: <20241206220001.164049-9-lizhi.hou@amd.com>
On 12/6/2024 3:00 PM, Lizhi Hou wrote:
> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
> fail.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Reported-by: Mike Lothian <mike@fireburn.co.uk>
> Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/
> Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Slight problem with the SOB chain which prevents me from applying this.
Mike comes first, which indicates he authored this patch. Then you,
which says you took Mike's patch and are moving it forward. However,
since you sent it and it doesn't have "From: Mike", you get listed as
author.
Either Mike needs to be the listed author, or a Co-developed-by tag for
Mike needs to be listed immediately before his SOB.
With either of those:
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
next prev parent reply other threads:[~2024-12-13 16:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 21:59 [PATCH V2 0/8] AMD NPU driver improvements Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 1/8] accel/amdxdna: Add device status for aie2 devices Lizhi Hou
2024-12-11 0:31 ` Mario Limonciello
2024-12-13 16:31 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock Lizhi Hou
2024-12-13 16:33 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support Lizhi Hou
2024-12-11 0:30 ` Mario Limonciello
2024-12-13 16:37 ` Jeffrey Hugo
2024-12-13 16:47 ` Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray Lizhi Hou
2024-12-13 16:42 ` Jeffrey Hugo
2024-12-13 16:50 ` Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 5/8] accel/amdxdna: Add query firmware version Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-13 16:48 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 6/8] accel/amdxdna: Enhance power management settings Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-11 5:28 ` Lizhi Hou
2024-12-11 20:55 ` Mario Limonciello
2024-12-13 16:55 ` Jeffrey Hugo
2024-12-13 17:31 ` Lizhi Hou
2024-12-06 22:00 ` [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers Lizhi Hou
2024-12-11 0:20 ` Mario Limonciello
2024-12-11 5:32 ` Lizhi Hou
2024-12-13 16:58 ` Jeffrey Hugo
2024-12-13 17:02 ` Lizhi Hou
2024-12-13 17:11 ` Jeffrey Hugo
2024-12-06 22:00 ` [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
2024-12-10 20:54 ` Mario Limonciello
2024-12-13 16:20 ` Jeffrey Hugo [this message]
2024-12-13 16:42 ` Lizhi Hou
2024-12-13 17:00 ` [PATCH V2 0/8] AMD NPU driver improvements Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7add90f-3d78-9ced-655f-a1918fb04af3@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=king.tam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=mike@fireburn.co.uk \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®