From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f225.google.com (mail-oi1-f225.google.com [209.85.167.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95FFE38F921 for ; Thu, 22 Jan 2026 19:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769109890; cv=none; b=WTNNrv8LbX2baatZ1lyOJYt02Abax39ylJO5NHheccp7RKJUF93GBLAD5TyBmX1MT2d56pTSAPoD3+Kg4pZ55+9h5fgntya5pU18CB6n3VPG8fe0zha+jIdfQW8GseK6lQ/+R0hckneWuP5Sb/uQHQKubsCvY2tfBiWiK/lv9+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769109890; c=relaxed/simple; bh=GvXk4V9By1D5PBjofkvhUU4qulOtHL+4ytfRSMIiTwQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AQt49S1hxBCHxhISvZBQ6wKxS9QQtgIdwyEFnQJv/L5t2OLG6WSySxGzZYCMbbrnuZxjQWlu8TPWiYzOPOt+f+AQOX6Yk3YIv9kknZCIBsu/WApDiUFLYUSukx7MrYL9UJSLjc839uydmzc3QMSNcNVwFQ1anvitWZNojGbQazw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=acWLR66u; arc=none smtp.client-ip=209.85.167.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="acWLR66u" Received: by mail-oi1-f225.google.com with SMTP id 5614622812f47-45c89ea958dso761674b6e.2 for ; Thu, 22 Jan 2026 11:24:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769109880; x=1769714680; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R1gfDRebGX8h9HwfZ81icDjDx7dxW6g0V3ctKkIDrxQ=; b=J6Hjv+k+wHsVIl94FsgPvsO5sduod2zEdBU8pUNE2LhMm+vluUP1/LS9fPJeg6AT0U SQN0d0S8KEvDH9CJgZt0zF4/JQbF154QbFqXUHHRsYMh/Ig/5rVDRZKeJYKJuktO5337 3iv0TkR1PSks/gL9+E6qep4Q3Nw8RbHr2fefImwONHSXDIJM7bKakLhZAIaQiXVu3gxa AT74ZF/RseNIypkOok2nq4mvbU17Bf82diGPnKJO/SDmSA+FQU+Hsx4p5WNUEoc1KfYw DYKl0Bd+opONByepHrSqo3xyLGgSB9M/fQP5p+r8V5p9HEt24tazfBhJBL/6X4eeWDaP rY0Q== X-Gm-Message-State: AOJu0YzccIa2Ik3/09YoM2EafxeaKcGhbBcPXwflitqQgcWqSSVjku2+ Bqhof3XkRbQSB298/jQ+5ZrzuxIClyMFuQAcc2JOimUSkiHgZVFAFJO29yyVoJeJpivMASlFDXA QJAXj3ae08N5CrQZQPSvdGokMJAt4dsLuwYJyRjBaGqepBPuNnc01qHewraGa+/wOALkQJPlQe6 NVLgWBV7xfBEYGx+cB3icCTRzK//rIvVQJBCpIT0fa84Tkh0O2GAMzG7sCk4oyiH+E19FZ9WH9F b7IjUDVv2pgDG3JiiaJS86H X-Gm-Gg: AZuq6aJSZJfOwerSI3XcAbAvwMlRTwQ9O2OJU4W2qiolKDO0eVb8t4HaCylsX+bZyq4 QxZ/dgv5D0LyuKFByONWHLquTO+KH0ezw7z07Y0UCEOIProFmNbDwzQq33iu/yGvRuIDiDRHJBl PgWI5Dtjk5uKpwpLVmIHix8uhFCWsipbt2XHGivDO5Fy02I4SWlZzxQ8+IyKd2L+6fU96zUJ1BR 4atOgtvagqaN8gPQ0C6dC9y7RLj1If+9lup4EUyAMoXPcErE5PHWZ7k3NU6+FgdjeHI2ouvKov9 9rP5vn7joFhvZ4MbzUYF7hJq4FJcnLZuZeXq3wUDKMaqmLFGh0/xtCTfJL76g6jh09Q75HWGtst DpHWZX2wP05pmokZRRMVrddkTYkkBd3fSJeebYYsq7DoOH3E+CvYLL2p1OGePpAP3OYFVyqvtYh aBrFC5hkmX/6aeaH/jAA2cHiewD08FAPiwoUQmiGh6hx74fbQ= X-Received: by 2002:a05:6808:1585:b0:450:4a1a:f2fe with SMTP id 5614622812f47-45eb1928393mr399593b6e.0.1769109880591; Thu, 22 Jan 2026 11:24:40 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-408afc00ba3sm4315fac.16.2026.01.22.11.24.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2026 11:24:40 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-11b94abc09dso2097812c88.1 for ; Thu, 22 Jan 2026 11:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769109879; x=1769714679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=R1gfDRebGX8h9HwfZ81icDjDx7dxW6g0V3ctKkIDrxQ=; b=acWLR66umiz4/L3DVnvzJGBfd6x5y3GARY0Pu8gRMHZIFpkzez7ZqcENNPjETigZVI m1Vv+nsJsSQv14qj7ziK6D2WKHBUH8eHDP1BrGhdA1MopuofYXmLG7BmPjVMihbfmar5 WzyzGJ+Fq8oLUt0Osb9Oh+D4L+trDeqHL2fNg= X-Received: by 2002:a05:7022:fa3:b0:11a:6424:f40f with SMTP id a92af1059eb24-1247dbfece5mr232986c88.36.1769109878971; Thu, 22 Jan 2026 11:24:38 -0800 (PST) X-Received: by 2002:a05:7022:fa3:b0:11a:6424:f40f with SMTP id a92af1059eb24-1247dbfece5mr232966c88.36.1769109878325; Thu, 22 Jan 2026 11:24:38 -0800 (PST) Received: from [10.63.25.133] ([12.75.221.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa22707sm304637eec.29.2026.01.22.11.24.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 11:24:37 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 11:24:35 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] gpio: brcmstb: allow parent_irq to wake To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Doug Berger , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Christophe Leroy , "open list:GPIO SUBSYSTEM" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20260122010516.1200630-1-florian.fainelli@broadcom.com> <20260122010516.1200630-4-florian.fainelli@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/21/2026 11:42 PM, Andy Shevchenko wrote: > On Thu, Jan 22, 2026 at 3:06 AM Florian Fainelli > wrote: > >> The classic parent_wake_irq can only occur after the system has >> been placed into a hardware managed power management state. This >> prevents its use for waking from software managed suspend states >> like s2idle. >> >> By allowing the parent_irq to be enabled for wake enabled GPIO >> during suspend, these GPIO can now be used to wake from these >> states. The 'suspended' boolean is introduced to support wake >> event accounting. > >> Signed-off-by: Doug Berger >> [florian: port changes after generic gpio chip conversion] > > Likewise in the previous patch I think this deserves the Co-developed-by tag. OK. > >> Signed-off-by: Florian Fainelli > > ... > >> + if (priv->suspended && bank->wake_active & (u32)status) { > > Why casting? status is an unsigned long, which is what for_each_set_bit() expects, so it is intended here to ensure the top bits are not participating in the comparison, I think this is just being extra explicit with intent here. > >> + priv->suspended = false; >> + pm_wakeup_event(&priv->pdev->dev, 0); >> + } > > ... > >> static void brcmstb_gpio_shutdown(struct platform_device *pdev) >> { >> + struct brcmstb_gpio_priv *priv = dev_get_drvdata(&pdev->dev); > >> + /* disable interrupts */ > > A useless comment. Indeed. > >> + if (priv->parent_irq > 0) >> + disable_irq(priv->parent_irq); >> + >> /* Enable GPIO for S5 cold boot */ >> - brcmstb_gpio_quiesce(&pdev->dev, false); >> + brcmstb_gpio_quiesce(priv, false); >> } > > ... > >> static const struct dev_pm_ops brcmstb_gpio_pm_ops = { > >> + .suspend_noirq = pm_sleep_ptr(brcmstb_gpio_suspend_noirq), >> .resume_noirq = pm_sleep_ptr(brcmstb_gpio_resume), > > May we use one of the PM macros for these two assignments? Sure, can do that! -- Florian