From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66AB6ECAAA1 for ; Fri, 9 Sep 2022 16:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbiIIQSS (ORCPT ); Fri, 9 Sep 2022 12:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbiIIQSQ (ORCPT ); Fri, 9 Sep 2022 12:18:16 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D98E225FD; Fri, 9 Sep 2022 09:18:15 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2895aPIn014512; Fri, 9 Sep 2022 11:16:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=0LNLMREyF5kJJgwuJGbEQYx89rPhx/7FxKJ+y8sHgso=; b=M74U+SR/xFOyjL5Yd8vaYN5nOMG05D2LuG2ZLLequWgbIJBMSLIFBIKks71n5joggxPt DsYDofPEu/Tibf/3TlUnGfgrDm81ZycDq0UUIzo4ky4uXnh3Z7wLYPr+N0s7E/2/ifcl iM8qcqz/dhihehviCf2CmvFR6pSxp9XLByzAEeQ+9C+qTdFquAJSA9g1A4j06QD8SENv aFVSTgHqNkcDruyTrr0PFKNFdTtjugloZEgcCdx1wVI7lcw/LpvcZrOFD57wWPMAkeKZ f4TLnuf9Qdb75KhlENf08rMpWMI7YY8iqHFnLc9C6uIq3JUb5dRJoJdSMbGm+lGwoHWu fw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3jc4b2hu9x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Sep 2022 11:16:50 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Fri, 9 Sep 2022 11:16:48 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.12 via Frontend Transport; Fri, 9 Sep 2022 11:16:48 -0500 Received: from [198.90.251.95] (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.95]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 474012C5; Fri, 9 Sep 2022 16:16:48 +0000 (UTC) Message-ID: Date: Fri, 9 Sep 2022 17:16:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 00/10] Support for CS42L83 on Apple machines Content-Language: en-US To: =?UTF-8?Q?Martin_Povi=c5=a1er?= , James Schulman , David Rhodes , "Lucas Tanure" , Liam Girdwood , Mark Brown , Rob Herring , "Krzysztof Kozlowski" , Jaroslav Kysela , Takashi Iwai CC: Charles Keepax , ChiYuan Huang , Pierre-Louis Bossart , Lukas Bulwahn , Matt Flax , - , , , , References: <20220909135334.98220-1-povik+lin@cutebit.org> From: Richard Fitzgerald In-Reply-To: <20220909135334.98220-1-povik+lin@cutebit.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: hV03cIsYarymZq2cwhZT7i_S0oaKwdrQ X-Proofpoint-ORIG-GUID: hV03cIsYarymZq2cwhZT7i_S0oaKwdrQ X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2022 14:53, Martin PoviĊĦer wrote: > Hi all, > > there's a CS42L83 headphone jack codec found in Apple computers (in the > recent 'Apple Silicon' ones as well as in earlier models, one example > [1]). The part isn't publicly documented, but it appears almost > identical to CS42L42, for which we have a driver in kernel. This series > adapts the CS42L42 driver to the new part, and makes one change in > anticipation of a machine driver for the Apple computers. > > Patch 1 adds new compatible to the cs42l42 schema. > > Patches 2 to 7 are taken from Richard's recent series [2] adding > soundwire support to cs42l42. They are useful refactorings to build on > in later patches, and also this way our work doesn't diverge. I made > one fix: I added a call of common_remove at the end of i2c_probe should > the cs42l42_init call fail (both before and after the split to > cs42l42-i2c.c). Also s/Soundwire/SoundWire/ in the changelogs. > Mark: I've no objection to you taking my patches from this chain instead of waiting for me to re-send them myself. I can rebase my remaining patches onto this chain. But I do have comments on patches #4 and #7. I've been very busy and don't have time right now to deal with re-sending my original patch chain.