From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332AbcHPIQM (ORCPT ); Tue, 16 Aug 2016 04:16:12 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:19803 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbcHPIPf (ORCPT ); Tue, 16 Aug 2016 04:15:35 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-f796c6d000001486-5b-57b2cb9a9a53 Subject: Re: [PATCH 2/7] Documentation: bindings: Add Exynos5433 PMU compatible To: Chanwoo Choi , kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1471328843-26653-1-git-send-email-cw00.choi@samsung.com> <1471328843-26653-3-git-send-email-cw00.choi@samsung.com> <488f925b-4c37-1759-04a8-11d992405527@samsung.com> <57B2C9EE.6000005@samsung.com> Cc: krzk@kernel.org, jh80.chung@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, jonghwa3.lee@samsung.com, beomho.seo@samsung.com, jaewon02.kim@samsung.com, human.hwang@samsung.com, ideal.song@samsung.com, ingi2.kim@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, chanwoo@kernel.org From: Krzysztof Kozlowski Message-id: Date: Tue, 16 Aug 2016 10:15:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-reply-to: <57B2C9EE.6000005@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t/xK7qzTm8KN1i1QNXi1rpzrBanP21j t3i/rIfRYuKNKywW1788Z7WYfwQosXRGH6vFrr/3GS123PzCZjHp/gQWix0NR1gtbvxqY7Xo PPuE2eLFvYssFq9fGFr0P37NbHH+/AZ2i02Pr7FaXN41h81ixvl9TBZrj9xlt1h6/SKTReve I+wWh9+0s1rMmPySzeLlxxMsDlIea+atYfTYtKqTzWPzknqPvi2rGD0+b5ILYI3isklJzcks Sy3St0vgyph84R5zwRL+ilXTnzA3MF7n6WLk5JAQMJE4MmUzI4QtJnHh3no2EFtIYCmjxMPF xiA2r4CgxI/J91i6GDk4mAXUJaZMye1i5AIqecYosfj9LXaQGmEBf4nPJ6ewgyREBGYzSWw4 +ZIJYtBqJoldG/1AEswCL5kkVt87BdbBJmAssXn5EjaIDXYSN/csZQGxWQRUJb5OX8AKYosK REjcWvUR7DpOAW2JvR9WgQ1lFpCXOHjlOcsERoFZSA6chXDgLCRVCxiZVzGKppYmFxQnpeca 6hUn5haX5qXrJefnbmKExOeXHYyLj1kdYhTgYFTi4T3JsClciDWxrLgy9xCjBAezkgiv7ymg EG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhizMpIUHiQJ NgtpW4V/cbBI/8+ToLFiau0Nxo3yjs3va9cpxpe8N+Kc6L+xIap0scurp5wzC7laRP7mVEYv eHBTOyRTRJ9pn+8th0PCmgLK99auquH8x6vG+2j5St6youO/P5q7ejiqep412vVkwed5vld/ zpMSNNy5YR3vxSI+j1nN7089+K3EUpyRaKjFXFScCAB4epnJywIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2016 10:08 AM, Chanwoo Choi wrote: > Hi Krzysztof, > > On 2016년 08월 16일 16:40, Krzysztof Kozlowski wrote: >> On 08/16/2016 08:27 AM, Chanwoo Choi wrote: >>> This patch adds the exynos5433 PMU compatible to support the access >>> of PMU (Power Management Unit) block. >>> >>> Cc: Kukjin Kim >>> Cc: Krzysztof Kozlowski >>> Cc: Rob Herring >>> Cc: Mark Rutland >>> Signed-off-by: Chanwoo Choi >>> --- >>> Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt >>> index 2d6356d8daf4..bf5fc59a6938 100644 >>> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt >>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt >>> @@ -10,6 +10,7 @@ Properties: >>> - "samsung,exynos5260-pmu" - for Exynos5260 SoC. >>> - "samsung,exynos5410-pmu" - for Exynos5410 SoC, >>> - "samsung,exynos5420-pmu" - for Exynos5420 SoC. >>> + - "samsung,exynos5433-pmu" - for Exynos5433 SoC. >>> - "samsung,exynos7-pmu" - for Exynos7 SoC. >>> second value must be always "syscon". >> >> Is there any plan to add Exynos5433 support to >> drivers/soc/samsung/exynos-pmu.c? If no... then exynos7-pmu might be >> reused. If yes, then this makes sense. > > Yes. > I'll support the suspend-to-ram for Exynos5433. But it is not right now. > because the current kernel support the suspend-to-ram for only 32-bit Exynos. > and the pm/suspend code are included in in arch/arm/mach-exynos/. > > To support the suspend-to-ram for 64bit Exynos, I need a lot of time > to support the 64-bit suspend. OK, make sense. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof