From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B537738C2A9 for ; Wed, 15 Apr 2026 20:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286294; cv=none; b=V0pA8RbI8mh5IYOe/GJElPRCE67//g8aJ1QxLFGvtcUMlBbLkOVHHquZHHruKlbPM/mmvQYZ129zM9HhQXZTkYeOJNNi1OppJcQomU1yKFamp8tSWj8dKRMH2rOHUtKhEWlwdtgwinB3xc0mwG6oDhJoZoLIMMd8H4rDy/s/ApI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776286294; c=relaxed/simple; bh=1p8NSnHp2ZoIeGaQzlfVeCNqKATnjU5veK4IJvrBahE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IXtoSuHAIfXbnDSuZpCOosGebo9qKUex+R7TCCSBEsZMycTb8ZVtqtxfG0zcSZssV9EIuoWM8jTk47fLoTnPc7oHTk5ZL06H6sDdrbL6XMnOyPBkuwL4krLt4GIh1ovchHyIpj66CpQZYANNvMzTA+wG0F4+N1djzFnMcDQ65hM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ng5BTxKh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rsw83pdO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ng5BTxKh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rsw83pdO" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63FEkHnE3733590 for ; Wed, 15 Apr 2026 20:51:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uQkGrBvY1Q6Phw3ZndsRhOHv20pp4HB0vkTp3Pi0WBs=; b=ng5BTxKh1LnpJvZF Dr4EpzBnHj0FodO3QYrpfICS57mZGnKyqpTHGC6imcUxDsLQ4hl9N1Pz9caxfUuJ D8sZqGPQvnLloWQjuEqpEBEtRP+alrOBWFMLOzGMO9+wY8MapPJ/f/ODwEE5ILTn m5kycPBXjlVj5+YO8VYK8jXHjcaP4Bkk0nQPqr3z2PP560Ymq1GrTlwwtIp1L+Mn BaidGiNlV1qj41Tpi/TOGrjk475/bUZVgu1U97u8kVGryeiGnkVggF+y+z6OQy4S X0cLpm5RESI3oz2TDib+P3BGgS9ZAEqKdVW/HcI0dTZHrvHUIbGsh6CGZLv3Wk3d tGtGVg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djcqwh6ks-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Apr 2026 20:51:30 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-354490889b6so10500224a91.3 for ; Wed, 15 Apr 2026 13:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776286290; x=1776891090; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uQkGrBvY1Q6Phw3ZndsRhOHv20pp4HB0vkTp3Pi0WBs=; b=Rsw83pdOJp5i8feJouvkYfuf87uGWOhUI6gVK5slheA+1JtOMEa/jAEh1SR91XqTKJ U6VvJk07n0a0gpg8R69BglX4ArFAnXplTmiGDLQZWUjy3DnVQ5EoE7j8EeLWlRrOd7S0 Xo5fYHuqzV0WYbo0nvbsfmAVaEx3htLfPsnM9dz0EeIcHkoa3OfsEW+iApottVKuGNZ5 sf3JVDJaQY35eFq7jD2HBHHHiWxAatxlDzMgRpE6VihOyDWRWp/F+zMNY2MloCKrN3+c nhs+UD9X8ew13/hLul/H0SHDyUBdxVGLiZgj10meWtjQaORwhdIqF8Uskc8BfGQVxlX+ qBww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776286290; x=1776891090; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uQkGrBvY1Q6Phw3ZndsRhOHv20pp4HB0vkTp3Pi0WBs=; b=r6uzmUDLYZfq1HJesVWLufvvYzGoovQvdjv1EdJL/Ck76YPlb+5WPEeJoSf1ib+tj0 5pEmlryt2mMVfgaVGsJ9WnLYugoaI1DyfHWwuhjlUy59XETSHLB/r4j0CRwN3P9bVPXV K7kgkzobVGVDLaTkAz57CyRpG+ZqTIKCQFLu1Pu5l7bxjEU3A/Sqo9UWkovbxvfxEJPK uS4LSxpwB4c8z62TcPiM49r4c9NTAL2OiLPiCLPGhy/qygw9BVuPQ3IXWCjO15tBOH3U M3nFFdq37JnbQci5j/G36xzm5mSDKBC8LMDSOhASiDTAmLfidmkHjd5xz+IHJ4xSrjCu eFLg== X-Forwarded-Encrypted: i=1; AFNElJ/Xpsc5nBRw5YlExg2u7NES8QtzHe245+BOwI3BHw2lMnrFHQzzkEzeK7oXc0SY3HnxK3kuUsO5W24bmcQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd0w417ZjcbO8qCZ5IDTnW1v6LjxRUTOrJ3XlZsvujlG6znvtH c3IEhb6Kt2rwz4mFj9jJ+T4zJ2EOCF3e8g2xFR2Wa7EX+AZKxNg1Mvvih2K8IyEmFTmgCvFh3Ck jgsn6hNE8SA92baoG8w4HrKa+Ozovmcie2MeFBAOwY4WhnPze/ABv5DYD3byGT+5a77c= X-Gm-Gg: AeBDietpxYVmsAWTQS4rJB/B7FeOIyvPYepxPw85dgxFz0eW0u1oup/BnmMvgyG+McD tf2/LY0jMA1JkDsVm+2WIzUAwCt1N2bQMMDNFsA9DPd8ALv2BNZ9yrvHNJTIS8C/4+d5+4ADWd/ 7YgS0JDIDu9vQ5pGC91Ui9DtN+uwHO2SkcW8KNGzhsV7tW9BIk1z+D7oDadFtOWmNuIiXxvMdkB EfMot7xxEhTbiGKPjM/GunrzJhFnhKT97kDL5/lcWhKtiD0geYuxuSykuSA8zpN1RaQgKlwDiO1 AKgAxq6fBBRrxC+WdE3BhgnxkBZzqTNLnU22lZ7jvNAwaXEaKUq24RhQW4P30oJphGA9Nxp7s7M umnKy+SflZqwPRcNFuxI9MB2uhqexkezDRCmQK9aPtOvkWVKgAOmVXTA= X-Received: by 2002:a05:6a20:a111:b0:398:89b6:1b41 with SMTP id adf61e73a8af0-39fe3f5a009mr26877732637.32.1776286290204; Wed, 15 Apr 2026 13:51:30 -0700 (PDT) X-Received: by 2002:a05:6a20:a111:b0:398:89b6:1b41 with SMTP id adf61e73a8af0-39fe3f5a009mr26877711637.32.1776286289726; Wed, 15 Apr 2026 13:51:29 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79581a3015sm2487185a12.16.2026.04.15.13.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 13:51:28 -0700 (PDT) Message-ID: Date: Thu, 16 Apr 2026 02:21:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] drm/msm/a6xx: Limit GXPD votes to recovery in A8x To: Konrad Dybcio , Taniya Das Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-6-4bb5583a5054@oss.qualcomm.com> <8f5ffecc-007e-4a8a-9c5e-9994e7841659@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3ZgnUm9K2movLKa51Jl8hhtYi2hAqB8W X-Proofpoint-GUID: 3ZgnUm9K2movLKa51Jl8hhtYi2hAqB8W X-Authority-Analysis: v=2.4 cv=XOIAjwhE c=1 sm=1 tr=0 ts=69dffa52 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=tjBgj1cQHot02RtnpFkA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE1MDE5NSBTYWx0ZWRfX8scJolicHp1G TYWRQiUJXguC9x8Fw36qeO8SAoG4yJvsoyDb6eJYox0CsCYopbgbX7TY8PCf9WVnapN3B7ZXr9G YL9AaB72vZMraPq0idCCYwZyivH9tXE1R4pOCMMX0jIiy3ecLu+PLn79IHYip839+XzCuf7JE4q 8j8BWjx5lF8BuW1UC2zcpfllvsVztVnKl4SXaQa8dOB7YKbrY26v0vePz3L1Z7a8AwmmlZ7KFky uqAYAiy2OVKL8L7R7p+L4U+i7QVaVkqc/BuMPAUPsmn0u2RFp8f1PQ+FswvNdBAlkhnHzg6Op2U nTHZ06vbM9KcIVITeBMH62XcuinFMx/Paf0p81nZHS41cJhclLxUuy3dR4InXoA7LDRHawjs+e+ gIpz7xeNHdfUtT3c7lIRuPKmHLpOTWCmHzlAoF/r2JqjkNO96IaXeACHEfBtdcAdtiPzP0O2s1a 9WUn2E8FTxKoe5MyaeA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-15_01,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150195 On 4/14/2026 7:58 PM, Konrad Dybcio wrote: > On 4/7/26 9:16 PM, Akhil P Oommen wrote: >> On 4/7/2026 4:31 PM, Konrad Dybcio wrote: >>> On 4/7/26 11:30 AM, Taniya Das wrote: >>>> From: Akhil P Oommen >>>> >>>> In A8x GPUs, the GX GDSC is moved to a separate block called GXCLKCTL >>>> which is under the GX power domain. Due to the way the support for this >>>> block is implemented in its driver, pm_runtime votes result in a vote on >>>> GX/GMxC/MxC rails from the APPS RSC. This is against the Adreno >>>> architecture which require GMU to be the sole voter of these collapsible >>>> rails on behalf of GPU, except during the GPU/GMU recovery. >>>> >>>> To align with this architectural requirement and to realize the power >>>> benefits of the IFPC feature, remove the GXPD votes during gmu resume >>>> and suspend. And during the recovery sequence, enable/disable the GXPD >>>> along with the 'synced_poweroff' genpd hint to force collapse this GDSC. >>>> >>>> Signed-off-by: Akhil P Oommen >>>> Signed-off-by: Taniya Das >>>> --- >>> >>> Can we simply make this change unconditional on the gen, so as not to >>> maintain 2 separate code paths that try to achieve mostly the same thing? >> >> We can skip the gdsc vote on A8x because the 'gdsc disable' callback is >> dummy when the synced_poweroff hint is not set. Otherwise, gdsc may get >> disabled during system resume while GMU assumes the ownership. Taniya >> touched upon this point in the cover letter: >> >> """ >> when GX GDSC is managed through the generic GenPD runtime PM >> framework, it can be unintentionally disabled by the OS during system >> resume (resume_noirq/complete phases) or runtime PM suspend paths. >> """ > > Right, but if we made the GDSC.disable() a dummy on all platforms this > could be done. > > On a second thought though, this won't work for gmu_wrapper, so we'd > need two paths either way. gmu_wrapper uses a different code path for pm_resume/suspend anyway. So, that is not a problem. Perhaps, we can explore this separately as it would impact a lot of chipsets. I would like the get this series merged ASAP to unblock A8x support. -Akhil. > > Konrad