From: Rik van Riel <riel@surriel.com>
To: Dave Hansen <dave.hansen@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] x86,tlb: update mm_cpumask lazily
Date: Fri, 08 Nov 2024 15:41:43 -0500 [thread overview]
Message-ID: <a7cffa2a68a7c9e40357b3300220c5eb0065e86b.camel@surriel.com> (raw)
In-Reply-To: <1df2caa3-4c5d-4bd9-88bb-66a07bf1eb65@intel.com>
On Fri, 2024-11-08 at 12:31 -0800, Dave Hansen wrote:
>
>
> The only thing I can think of that really worries me is some kind of
> forked worker model where before this patch you would have:
>
...
> Where that IPI wasn't needed at *all* before. But that's totally
> contrived.
>
> So I think this is the kind of thing we'd want to apply to -rc1 and
> let
> the robots poke at it for a few weeks. But it does seem like a sound
> idea to me.
>
I am definitely hoping the robot will find something to throw at this
workload that I didn't think of.
Most of the workloads here are either single threaded processes, or
heavily multi-threaded processes.
For the worker process case, I would expect us to COW and flush a
number of pages in close time proximity to each other. In that case
the first IPI may get sent to an unnecessary CPU, but future IPIs
in that batch should not be.
If we don't send many invalidation IPIs at all, we probably don't
care that much.
If we do send a bunch, they often seem to happen in bursts.
I don't know if there are workloads where we send them frequently,
but not in bursts.
--
All Rights Reversed.
next prev parent reply other threads:[~2024-11-08 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 19:31 Rik van Riel
2024-11-08 20:03 ` Dave Hansen
2024-11-08 20:07 ` Rik van Riel
2024-11-08 20:10 ` Dave Hansen
2024-11-08 20:31 ` Dave Hansen
2024-11-08 20:41 ` Rik van Riel [this message]
2024-11-08 20:46 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7cffa2a68a7c9e40357b3300220c5eb0065e86b.camel@surriel.com \
--to=riel@surriel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®