From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: linux-kernel@vger.kernel.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH kernel] panic: Dump registers on panic_on_warn
Date: Wed, 29 Jul 2020 18:24:26 +1000 [thread overview]
Message-ID: <a7d3459b-77f5-a65a-c407-e332d1b921ab@ozlabs.ru> (raw)
In-Reply-To: <20200630093846.100531-1-aik@ozlabs.ru>
Ping?
On 30/06/2020 19:38, Alexey Kardashevskiy wrote:
> Currently we print stack and registers for ordinary warnings but
> we do not for panic_on_warn which looks as oversight - panic()
> will reboot the machine but won't print registers.
>
> This moves printing of registers and modules earlier.
>
> This does not move the stack dumping as panic() dumps it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> kernel/panic.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index e2157ca387c8..798eff8156f3 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> if (args)
> vprintk(args->fmt, args->args);
>
> + print_modules();
> +
> + if (regs)
> + show_regs(regs);
> +
> if (panic_on_warn) {
> /*
> * This thread may hit another WARN() in the panic path.
> @@ -600,12 +605,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> panic("panic_on_warn set ...\n");
> }
>
> - print_modules();
> -
> - if (regs)
> - show_regs(regs);
> - else
> - dump_stack();
> + dump_stack();
>
> print_irqtrace_events(current);
>
>
--
Alexey
next prev parent reply other threads:[~2020-07-29 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 9:38 Alexey Kardashevskiy
2020-07-29 8:24 ` Alexey Kardashevskiy [this message]
2020-07-29 8:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7d3459b-77f5-a65a-c407-e332d1b921ab@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®