From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6F42749E6 for ; Thu, 23 Apr 2026 13:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776951067; cv=none; b=DYDipJi7xT7uelEbVoLo9W9OhvBT/AH2CSVxr+oFbkrVmxOBDVG4t0gpVXpBgJET4BWidhz1aFG19fHKqhm10knqrU3pgjGCS+Bqbd+tKelCmrLBTaatjO3mARXl/qjp5YKar55Q7TlscqzG4o/y0wiGk7COLZU8DMLTAU3kxC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776951067; c=relaxed/simple; bh=NxyTznSOVHDs+31Eml1fvnVenk68OjaS9nMMo6W2nbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k/uivfoefzHxyYou+mEGnpAfY0iPDPEsU8IhLD1IBHfM8v/QCAfUR9CLLKB+zLCtiEdAuLpzPhh7R9PGPvrcVg45GBevX47N0ZYi+krzKW2HE59lH4TVtUcJLkj/yYCwBMR42UvnPgFGRXhfVdxiRmudkuJTPWHqUeuiM5Xw0uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BR50L+kk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K9JqfEn1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BR50L+kk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K9JqfEn1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uPEM1565879 for ; Thu, 23 Apr 2026 13:31:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B2IrW4zJMm2y1QlRpdD4guuu/pN7EnUqJhKoxq7TncE=; b=BR50L+kkjLO0IEy/ VkbWsD6ZsB9CBu1l7/M9Iira0e7JdLvJBB5WNOXs8DvsIoey4/29xLzCAlE9TKPx hTNoJBP2v/Qj+z/O12BU+tEXY+XID7VXfj7KGSa5CIeCSEW2TkLQktswvNWhSyvh HT6XILpn/BU2CIgZROC+qfv6JVlw90mjU000YbbGTrn2XgdZwaHraHIveapRxByS QSiCdNaT2ARKJyzOq0rWFStWHuBzccnNRzvlzQreGNSrtJxvi2nb1h98Z2dUBgIc LZjMk5rAmCfPmiLGUIonEBCyilw98bSuhYZJ/Yt2uZosHdvzXr22yQy9bEtp3zKj dxpm6A== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16wv7hj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 13:31:05 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f0e12d375so4000957b3a.1 for ; Thu, 23 Apr 2026 06:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776951064; x=1777555864; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B2IrW4zJMm2y1QlRpdD4guuu/pN7EnUqJhKoxq7TncE=; b=K9JqfEn1mraVWNOjUBAmcBtaHfcAQs8OaqhOXdvFblTXTv1mViEuTL0TVEK7hEOhf4 Sn8JUpI5RQkqJZAehyMujHu5xD6mS5JxsyLwzQ3KaiUyXVW8ORpT034PsUxkKpMZV1EL g9NoC9qPG3ph3XuZZdSYt4Qtsd+eYOpZIVWnB7uxvpXB61ZOuOjQcyW2FJsS41yhrBi5 XVNcfcXg2ZiWpgoGE5tFvYhqaMNVqWn8O8q+IIY7xuIzie4g1AB5T7aKyiL2cYy3zd0C Ep57zHG84ylUjtnNmyoZ99ghP+YCTs4gPwIn5kih/OYPtrsjKdIsXDUEG5icY6u5ppNY 3RgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776951064; x=1777555864; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B2IrW4zJMm2y1QlRpdD4guuu/pN7EnUqJhKoxq7TncE=; b=kuo3GfOHd9Lxdzfq/IBip+1ItxhFnM6hHzCf3WR3kPBhjzxfq8VjL4gNZA7Tu7dKhY FAfM06zt02PmPgcjFIPCoQMI5sAD0xQk86wbzFy779d6tLe2Z4rWEpVKNDKtYcgsMJWZ q6YOmygvnhp48KAQXrVpeT8rcN6tGzzCBciRz0A8DvVVK2pMGjRlRtotrbeuXYZgqZgV 1bfHwgsyzZIWG6mdDFS84an2EF6gboAkVPkZHdtGZPN1/GJwt2eQcu92Ss4Y+/D3OKkB kCZOHJ3bkTB4mEChbz1y9tXTnm/RMHnB7NolkvECYVD8N3ESNJwWwSIQth1Hv9XEf1LK C9ow== X-Forwarded-Encrypted: i=1; AFNElJ/sbWIQW0ahoKmL90zUP2Mo9V3QRcj0GLdx/rIEq3nLaPLQcWj0+JrQcb7FN5ju0AhMAIDGkBWOzPuQciU=@vger.kernel.org X-Gm-Message-State: AOJu0YwlJAdknY/bAFDcj3/sbg8AqXpySKgc0qTOF0Hz4mZaXeqAuz+s POTU9cG0hpk+3VbD5rt9m4lIu+LH5czjG3f76qtJ3+lxElAl5Ul1GKo0Tu3ezcaIsnVW53DIOkB dBISqz260H/hw9KFsoPoKs0Nmoo1QThuHUKezKqCPWMCMSkxVuUQUDzhndBkZi2e0Sd4= X-Gm-Gg: AeBDietPn6P+e5LxonjhaULUAvOy4utW9c8JTQY0QIegxP/yEEB3afupcVc2osOmigR yO5TfbCMw4exXtCeAPue6XYQqGKYNSHPAF7SPbZezXjOMVGUJ14mqdKrSGFwCzH3+LpBUjTBweY 9Rb3TxDES0TprHY914Kd82ylFE3ZoJ7wm+S26+0v/1NlJMHabiD1v3z9ITa5xSCHHz5k1tMIncP 2YbLcVUXlJU0umk2tvuBM0h7qBRAwOBp8ElIavClXQ1KglH6aEt+RVVStliock3jeEtycfuIAOc T5+NCJt/p+E1vJtYAg2J8hjY++wJcBGZo+SI2VWbIx2xtynR8v3sD8FfYOQzo5wWPueW2CNSjxq YaA3b2rwlDmJdpS6wa8yoU6/HGZ5PCx7J/7ekP40rOnX1zwUVQz9AC+6nbfyfLVEy+JcEVAlG0c VPO+p3r7v18btopNfx3oKz X-Received: by 2002:a05:6a00:8714:b0:82f:be7d:5fc0 with SMTP id d2e1a72fcca58-82fbe7d61c8mr12499499b3a.39.1776951064315; Thu, 23 Apr 2026 06:31:04 -0700 (PDT) X-Received: by 2002:a05:6a00:8714:b0:82f:be7d:5fc0 with SMTP id d2e1a72fcca58-82fbe7d61c8mr12499448b3a.39.1776951063667; Thu, 23 Apr 2026 06:31:03 -0700 (PDT) Received: from [10.133.33.37] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9fcea9sm25531703b3a.23.2026.04.23.06.30.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 06:31:03 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 21:30:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() To: Bean Huo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Keoseong Park , Daniel Lee , Ram Kumar Dwivedi , Huan Tang , Liu Song , vamshi gajjela , "Rafael J. Wysocki" , Adrian Hunter , open list References: <20260419135229.1036926-1-can.guo@oss.qualcomm.com> <20260419135229.1036926-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEzNCBTYWx0ZWRfX6uT2IpdJwZ5t QDrkdHeWaph8hpJLKIjAJHa3OszvqaK2isOcVR67K9xBfS0BrF+rtmx1OGbNMl4O6updSw7Ou5/ qoKAx4u3FZLT3WhT5WGNOFb+PAeKNlvgWIx1cp7IPblnSmlae2BGLr3uiFN1DwPmvEk4IwHIyRV ja0xVI2xQ7aT9zGGq54LS4eIDcemPv38KKbiS/N2IkWM7fiC5oORwKYXI24XiM+GWeLC6JpvZYk GDvg382mokS4AfVjQ9Qs2sp0AvRcK2SnOXZ+nt2ZPKqEa3MhoAFUgsfyemrZ+lV+ygcJSTJiNUq CaURo6w3jnqqaNcfuCaXAknqp4J0o9VTr+HWk2vAomx0KTof5zbE8wIN5mh9AmPJu2a0ToMQzvY stbW+n2/SoV9H5G5bQAPeX5CHrxA2qtlJhNodeM0XbrNXchzCTXHM+vd5bP3Q41PIrASpg0GYlj YG+XxxClksP1OWWe2UQ== X-Authority-Analysis: v=2.4 cv=dL+WXuZb c=1 sm=1 tr=0 ts=69ea1f19 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=1dNXFKBvIBPViYih24wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: AnGlfsnPaK2HXxwxKBEQazjZ_TdANHcl X-Proofpoint-ORIG-GUID: AnGlfsnPaK2HXxwxKBEQazjZ_TdANHcl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230134 On 4/21/2026 6:04 AM, Bean Huo wrote: > Can, > > > On Sun, 2026-04-19 at 06:52 -0700, Can Guo wrote: >>  static int wb_read_resize_attrs(struct ufs_hba *hba, >>                         enum attr_idn idn, u32 *attr_val) >>  { >> @@ -1736,6 +1747,7 @@ static ssize_t _name##_show(struct device >> *dev,                           \ >>         struct device_attribute *attr, char *buf)                       \ >>  {                                                                      \ >>         struct ufs_hba *hba = dev_get_drvdata(dev);                     \ >> +       u64 >> qword_value;                                                        \ > u64 qword_value __maybe_unused; > > >>         u32 value;                                                      \ >>         int ret;                                                        \ >>         u8 index = 0;                                                   \ >> @@ -1748,14 +1760,24 @@ static ssize_t _name##_show(struct device >> *dev,                         \ >>         if (ufshcd_is_wb_attrs(QUERY_ATTR_IDN##_uname))                 \ >>                 index = ufshcd_wb_get_query_index(hba);                 \ >>         ufshcd_rpm_get_sync(hba);                                       \ >> -       ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,       \ >> -               QUERY_ATTR_IDN##_uname, index, 0, &value);              \ >> +       if (ufshcd_is_qword_attrs(QUERY_ATTR_IDN##_uname))              \ >> +               ret = ufshcd_query_attr_qword(hba,                      \ >> +                       UPIU_QUERY_OPCODE_READ_ATTR,                    \ >> +                       QUERY_ATTR_IDN##_uname,                         \ >> +                       index, 0, >> &qword_value);                                \ >> +       else                                                            \ >> +               ret = ufshcd_query_attr(hba,                            \ >> +                       UPIU_QUERY_OPCODE_READ_ATTR,                    \ >> +                       QUERY_ATTR_IDN##_uname, index, 0, &value);      \ >>         ufshcd_rpm_put_sync(hba);                                       \ >>         if (ret) {                                                      \ >>                 ret = -EINVAL;                                          \ >>                 goto out;                                               \ >>         }                                                               \ >> -       ret = sysfs_emit(buf, "0x%08X\n", value);                       \ >> +       if (ufshcd_is_qword_attrs(QUERY_ATTR_IDN##_uname))               \ >> +               ret = sysfs_emit(buf, "0x%016llX\n", >> qword_value);              \ >> +       else                                                            \ >> +               ret = sysfs_emit(buf, "0x%08X\n", value);               \ >>  out:                                                                   \ >>         up(&hba->host_sem);                                             \ >>         return ret;                                                     \ >> > ... > > >> >> +/** >> + * ufshcd_query_attr_qword - API function of sending query requests for quad- >> word attributes >> + * @hba: per-adapter instance >> + * @opcode: attribute opcode >> + * @idn: attribute idn to access >> + * @index: index field >> + * @sel: selector field >> + * @attr_val: the attribute value after the query request completes >> + * >> + * Return: 0 for success, non-zero in case of failure. >> + */ >> +int ufshcd_query_attr_qword(struct ufs_hba *hba, enum query_opcode opcode, >> +                           enum attr_idn idn, u8 index, u8 sel, u64 >> *attr_val) >> +{ >> +       struct utp_upiu_query_v4_0 *upiu_req; >> +       struct utp_upiu_query_v4_0 *upiu_resp; >> +       struct ufs_query_req *request = NULL; >> +       struct ufs_query_res *response = NULL; >> +       int err; >> + >> +       if (!attr_val) { >> +               dev_err(hba->dev, "%s: attribute value required for opcode >> 0x%x\n", >> +                       __func__, opcode); >> +               return -EINVAL; >> +       } >> + >> +       ufshcd_dev_man_lock(hba); >> + >> +       ufshcd_init_query(hba, &request, &response, opcode, idn, index, sel); >> + >> +       switch (opcode) { >> +       case UPIU_QUERY_OPCODE_WRITE_ATTR: >> +               request->query_func = UPIU_QUERY_FUNC_STANDARD_WRITE_REQUEST; >> +               upiu_req = (struct utp_upiu_query_v4_0 *)&request->upiu_req; >> +               put_unaligned_be64(*attr_val, &upiu_req->osf3); >> +               break; >> +       case UPIU_QUERY_OPCODE_READ_ATTR: >> +               request->query_func = UPIU_QUERY_FUNC_STANDARD_READ_REQUEST; >> +               break; >> +       default: >> +               dev_err(hba->dev, "%s: Expected query attr opcode but got = >> 0x%.2x\n", >> +                       __func__, opcode); >> +               err = -EINVAL; >> +               goto out_unlock; >> +       } >> + >> +       err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY, dev_cmd_timeout); >> +       if (err) { >> +               dev_err(hba->dev, "%s: opcode 0x%.2x for idn %d failed, index >> %d, selector %d, err = %d\n", >> +                       __func__, opcode, idn, index, sel, err); >> +               goto out_unlock; >> +       } >> + >> +       upiu_resp = (struct utp_upiu_query_v4_0 *)response; >> +       *attr_val = get_unaligned_be64(&upiu_resp->osf3); >> + >> +out_unlock: >> +       ufshcd_dev_man_unlock(hba); >> +       return err; >> +} >> + > this needs a wrapper for retry? In ufshcd_extract_tx_eq_settings_attrs(), the > 32-bit dTxEQGnSettingsExt read uses ufshcd_query_attr_retry(), but the 64-bit > qTxEQGnSettings read uses bare ufshcd_query_attr_qword() with no retries. I will use the non-retry version in ufs_txeq.c to be symmetrical, because I don't really need retry - retry never helped in real cases. Thanks, Can Guo. > > Kind regards, > Bean