From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E6EDC433EF for ; Thu, 10 Feb 2022 18:33:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245752AbiBJSdv (ORCPT ); Thu, 10 Feb 2022 13:33:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242475AbiBJSdv (ORCPT ); Thu, 10 Feb 2022 13:33:51 -0500 Received: from smtp.smtpout.orange.fr (smtp02.smtpout.orange.fr [80.12.242.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DB9B192 for ; Thu, 10 Feb 2022 10:33:47 -0800 (PST) Received: from [192.168.1.18] ([90.126.236.122]) by smtp.orange.fr with ESMTPA id IEGEnOlbgeKJJIEGEn3FAs; Thu, 10 Feb 2022 19:33:44 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Thu, 10 Feb 2022 19:33:44 +0100 X-ME-IP: 90.126.236.122 Message-ID: Date: Thu, 10 Feb 2022 19:33:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of do_div() Content-Language: en-US To: Jakub Kicinski Cc: patchwork-bot+netdevbpf@kernel.org, Qing Wang , dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1644395960-4232-1-git-send-email-wangqing@vivo.com> <164441341163.22778.9220881439999777663.git-patchwork-notify@kernel.org> <056a7276-c6f0-cd7e-9e46-1d8507a0b6b1@wanadoo.fr> <20220209180113.3b3f0f5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Christophe JAILLET In-Reply-To: <20220209180113.3b3f0f5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 10/02/2022 à 03:01, Jakub Kicinski a écrit : > On Wed, 9 Feb 2022 21:01:35 +0100 Christophe JAILLET wrote: >> Le 09/02/2022 à 14:30, patchwork-bot+netdevbpf@kernel.org a écrit : >>> Here is the summary with links: >>> - net: ethernet: cavium: use div64_u64() instead of do_div() >>> https://git.kernel.org/netdev/net-next/c/038fcdaf0470 >>> >>> You are awesome, thank you! >> >> Hi, >> >> I think that this patch should be reverted because do_div() and >> div64_u64() don't have the same calling convention. >> >> See [1] >> >> [1]: >> https://lore.kernel.org/linux-kernel/20211117112559.jix3hmx7uwqmuryg@pengutronix.de/ > > Would you mind sending a revert? > I don't work on net-next, only linux-next. I can send a revert once it reaches linux-next but I would be better if it is fixed before that. CJ