From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F9633EAED for ; Tue, 21 Apr 2026 05:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776750895; cv=none; b=Y3mtfqZ0CpeIrLnJXmAQbobPzBfQ2MrYmJottCDUx50ewtOJfi69vd/zZvQGMWSin2sqFRt6GTo7mrSVwXxpDcn1t05KBxTqOCC6Z6K7xGq6shlWn+onOj+PXmKcHOM+KYKdlvTIG/xy8f1DOjKvr+r/vFMhN6wD1a6i7NjYblU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776750895; c=relaxed/simple; bh=E+WACzmadehe+65Ro3ESy5ryP0rzuSRqakiwWRPMjRg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vwgl/m5Vf+5dLNVYMw6Ldmnw1b312m7SPIfp+B2/6DfXYEv7HucqFF/Hud+O4rKa1GMc/tKy/cf/A/RH15NW9M1pYpi10qu5jjUrgBfqLw+gDBQ5MhNwj8ee9YCf1+09XBCq/oy/K2B2lqGT9mxLttYAcwZWXEdz+ahKHB96Bpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o2zdeDWe; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=caRglgls; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o2zdeDWe; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=caRglgls; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o2zdeDWe"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="caRglgls"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o2zdeDWe"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="caRglgls" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ADE886A7EF; Tue, 21 Apr 2026 05:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776750890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y2y+ffzHQP5VEF52auvPupBdDWRD2vDlY2bX3N4ZDc0=; b=o2zdeDWezGGo+YZBiOE5F1r0wvvIbahxElSsutWRn7wJMpXxY+Vxdl2tzWePU3dm+SgBkJ IPiEafciPgreCJQUV/MiVpJI3YDl6MAoOZW/mD8SMJf45IzNv6d0Ik+GApNVqtuC3xbJhZ 5GaMkucYhBvc+M4n1ctRqR4VFaEBxsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776750890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y2y+ffzHQP5VEF52auvPupBdDWRD2vDlY2bX3N4ZDc0=; b=caRglglsj/tvmCpp9wl5ZzzoYqdEV7bMFPwupYRe1CaaRS7YR0wIXIQD6thqYPeaUuUMSn CMUugSLY081faHDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776750890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y2y+ffzHQP5VEF52auvPupBdDWRD2vDlY2bX3N4ZDc0=; b=o2zdeDWezGGo+YZBiOE5F1r0wvvIbahxElSsutWRn7wJMpXxY+Vxdl2tzWePU3dm+SgBkJ IPiEafciPgreCJQUV/MiVpJI3YDl6MAoOZW/mD8SMJf45IzNv6d0Ik+GApNVqtuC3xbJhZ 5GaMkucYhBvc+M4n1ctRqR4VFaEBxsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776750890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y2y+ffzHQP5VEF52auvPupBdDWRD2vDlY2bX3N4ZDc0=; b=caRglglsj/tvmCpp9wl5ZzzoYqdEV7bMFPwupYRe1CaaRS7YR0wIXIQD6thqYPeaUuUMSn CMUugSLY081faHDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D76E593AF; Tue, 21 Apr 2026 05:54:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fllEJSkR52mMTgAAD6G6ig (envelope-from ); Tue, 21 Apr 2026 05:54:49 +0000 Message-ID: Date: Tue, 21 Apr 2026 07:54:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] drm/sysfb: ofdrm: fix PCI device reference leaks To: =?UTF-8?B?7LWc7Jyg7Zi4?= Cc: Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim References: <20260420002513.216-1-dbgh9129@gmail.com> <17620d92-70ee-4bc4-8944-4075bb50a54e@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-0.80 / 50.00]; SEM_URIBL(3.50)[psu.edu:email]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,lists.freedesktop.org,linux.intel.com,kernel.org,gmail.com,ffwll.ch,vger.kernel.org,psu.edu]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -0.80 X-Spam-Level: Hi Am 20.04.26 um 22:55 schrieb 최유호: > Dear Thomas, > > This issue was identified during our ongoing static-analysis research > while reviewing > kernel code. Specifically, an experimental static analysis tool found > that we are currently > developing. The tool is not public yet, so I prefer not to disclose > further project details > at this stage. AI was used only for cross-review, not as the primary > means of finding or > fixing the bug. I manually reviewed the code and verified the issue > before sending > the patch. Thanks. Best regards Thomas > > Best regards, > Yuho Choi > > > On Mon, 20 Apr 2026 at 02:21, Thomas Zimmermann wrote: >> Hi, >> >> thanks for the patch. >> >> Am 20.04.26 um 02:25 schrieb Yuho Choi: >>> display_get_pci_dev_of() gets a referenced PCI device via >>> pci_get_device(). Drop that reference when pci_enable_device() fails and >>> release it during the managed teardown path after pci_disable_device(). >>> >>> Without that, ofdrm leaks the pci_dev reference on both the error path >>> and the normal cleanup path. >> Did you use an AI to find or fix this bug? >> >> https://docs.kernel.org/process/coding-assistants.html >> >> Best regards >> Thomas >> >>> Fixes: c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers") >>> Co-developed-by: Myeonghun Pak >>> Signed-off-by: Myeonghun Pak >>> Co-developed-by: Ijae Kim >>> Signed-off-by: Ijae Kim >>> Co-developed-by: Taegyu Kim >>> Signed-off-by: Taegyu Kim >>> Signed-off-by: Yuho Choi >>> --- >>> drivers/gpu/drm/sysfb/ofdrm.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c >>> index d38ba70f4e0d3..247cf13c80a05 100644 >>> --- a/drivers/gpu/drm/sysfb/ofdrm.c >>> +++ b/drivers/gpu/drm/sysfb/ofdrm.c >>> @@ -350,6 +350,7 @@ static void ofdrm_pci_release(void *data) >>> struct pci_dev *pcidev = data; >>> >>> pci_disable_device(pcidev); >>> + pci_dev_put(pcidev); >>> } >>> >>> static int ofdrm_device_init_pci(struct ofdrm_device *odev) >>> @@ -375,6 +376,7 @@ static int ofdrm_device_init_pci(struct ofdrm_device *odev) >>> if (ret) { >>> drm_err(dev, "pci_enable_device(%s) failed: %d\n", >>> dev_name(&pcidev->dev), ret); >>> + pci_dev_put(pcidev); >>> return ret; >>> } >>> ret = devm_add_action_or_reset(&pdev->dev, ofdrm_pci_release, pcidev); >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com >> GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg) >> >> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)