From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45FA377550 for ; Thu, 5 Mar 2026 09:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772701511; cv=none; b=mRZ12twV7e6WuxN5+intQvRz795rwbRHKeN+fJjjyAKMLqp8850uBdOasBKcGUvx6pAJtlhyKev6EkxeHSJYAZFqHLg44aZv4hJVqHAfJfdb8D81PV1CW0fh+c9/Wzh+pn/EGFhcB26FHhv8TprALziMCDQxVWIuXZuHu/TCQ34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772701511; c=relaxed/simple; bh=2NzzHCCdd/kB0NsB8ylavg1VlVI8EYGbzeMbZGYYf88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i2QCWdhwWn5a6ynY0p2jv7hWBKW61PtJIdjiG+gIVCnPfq5GDTnH9E/PEaW7d61ZGy2F0Iz/WeTJpPkxsIFExdwJxURcOdcLckHVmeeT+0o2MqXVxmtS1ajqPaQcgWO89CazQnrwFOAWtGSnQ6yeKkLcxnpB3YHHIZkUOaqASsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RnKGKv5s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hnsniAvW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RnKGKv5s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hnsniAvW" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6258av441193218 for ; Thu, 5 Mar 2026 09:05:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jd7Nx7xGhxleQ6Tw6ZaCssdPU3vlLXlCP60azoPIZIU=; b=RnKGKv5sC4EVBYX+ 6vJWiKtNI5fcleUmMAYoIWVZ0ck6cNd3pbYqqv+XhBWZkRPRgz+3bdrT0tzTiNJi 4CwXpGRo8Klc8X7dUw80BX/Ohmf1WKy2pA9P12+iSmsCU/Qsci3i66cJgBvo+yIS 8L55GFrcmxmS7o2beUQiXSFC8x/VuV99McotLuhl95yJ6xRs1R1nqofD+o87zAq3 XVgqirMeT2yhCKqzRTXUv7hOor/ylC4zJg+w1JYyyRpsCtB/AxO8l3ku4EJCodmK vrThw+shk4JCkCA3LWdXVzLYVnXox2qFdCar9I18f502kh+Ze2EIqTBvaNtBTMv3 eYhH2Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpqwgau92-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 09:05:09 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb38a5dc3cso578453685a.3 for ; Thu, 05 Mar 2026 01:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772701509; x=1773306309; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jd7Nx7xGhxleQ6Tw6ZaCssdPU3vlLXlCP60azoPIZIU=; b=hnsniAvWVRITMWyizDnV2cRjfHkI3oNCNr8JrOUtry0Ejwazx/NjOkP0Vs/9MgJhK7 fNeSQMGKx3P6qdzavJh8HWx/kcD4qdiVLRfcDCax+DFDhShFZKC55qtNCKeAckRfd+Xp okRTZ8tl4at8jP85AJIA97P7uX+obQ2b4F8iI4Ke1SWOuIUX43PTK2cvESc6KEThdxH7 oGJ2NzeWvn39v+LX3gdxcaj8bCuXhQyASwjF7HUt0JasVnFYEM3fe464N3Y0+Ob+2d12 3qkSMfb0AJaK7EWkRq1iR0kAkmbwHcde1ZmzI+4bnBAA6bWtDZIC16bqqhxM1AKiLa8l EWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772701509; x=1773306309; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jd7Nx7xGhxleQ6Tw6ZaCssdPU3vlLXlCP60azoPIZIU=; b=CzD0+dXJxXie74abLlyDccwWEVMxWXDQYGYXS66hx2kBbGA7aVugRfBQd97cU2q7jx C3lpnEPcD+ue3jQ3TCn6dMv9rugjsIny5Hr/yHjm5wx59SUw64CGnog5pRiggyb6qtG1 2v008UQtiH1L2kJaCPpKU+ZPvBiUd8gJ9uf7IVMvD0134a8xeksB3etq7y4M4eTj8uOx hLvRWjUUfb3jehSxOipSuWRxj8DBHol8V0OvtNw5SiE/EKq/X0wr50ag0vG2Txx2Amhb i/251bNpRhmDLR/ZIrMsbrBUWKCWODEO9jNfExxtgXc9eY1dSFafsagWOzAVxqIir66/ CnYw== X-Forwarded-Encrypted: i=1; AJvYcCWZ2bIXgT9VdYYH88BSWbGeYvapSpy7FXzubBMc0SBRyc+0IQ8r1ikIm9OWiLSDKoNe1z1egM3l1B4KKe8=@vger.kernel.org X-Gm-Message-State: AOJu0YxcIsooKf/hJBVEcJ94lTQrE5ryTZzCPwcNRNRjzh5Tsy7ZTrQi dVgPpvn9Sz1MC+7MObLExF0Zl6mTuxfaJ2LnCIfvMW/aYlLgAx+hxtPuTbC18aJ9LImZfA+t8V5 yRTr2AsuUhezhIPEr/80jTtwZBNkFKlwwdZskLZvMnu0H/aKxqg0d6YBfpOU3jtSP2fQ= X-Gm-Gg: ATEYQzygTmhwlv/8Ds20VjjAnf/Eas/+xjVvo5peNMKiZDWyInUlbs7FpuhELQ714aC vbAdnmltnH76qAIo5NIBTksv5BX3MVc83qBrGgB4lJlW/Lypi0wrWIZtT6GGScJYE8BDeCzHtmJ sknhI1pxVLs21m/jwWt651PfZh9oh+7YmKzawSMjdbGCsYtDqgeYMBqfH1tPsgiCMwrwzJDdk+q coic5/ZTSeBQA9wuwhQnz3MOOURPkk3KNrrBo1Mb50JlU75v1ZPHf1zu11s2EhUc6qVVoiWbCqP q2usNumjSc70JRk0ck8GWu4taS9/oNoTn87Zr+nHbVqgc5NnI2Q5FuDdry2+pMjCGOnVdEJ2UNd cE39uK8WE+7Unvw6UrbVAwVlFCFIWhKMF2ipmzSk6BQ5M6gec1dHMWcO1vDaRKyV3pz33TMypXX S+ez4= X-Received: by 2002:a05:620a:700b:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8cd5afa9ac1mr542627485a.8.1772701508824; Thu, 05 Mar 2026 01:05:08 -0800 (PST) X-Received: by 2002:a05:620a:700b:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8cd5afa9ac1mr542622685a.8.1772701508311; Thu, 05 Mar 2026 01:05:08 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-660af3bf657sm2569281a12.5.2026.03.05.01.05.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 01:05:07 -0800 (PST) Message-ID: Date: Thu, 5 Mar 2026 10:05:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] clk: qcom: camcc-x1p42100: Add support for camera clock controller To: Bryan O'Donoghue , Dmitry Baryshkov , Jagadeesh Kona Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Konrad Dybcio , Abel Vesa , Rajendra Nayak , Stephan Gerhold , Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260304-purwa-videocc-camcc-v2-0-dbbd2d258bd6@oss.qualcomm.com> <20260304-purwa-videocc-camcc-v2-5-dbbd2d258bd6@oss.qualcomm.com> <2byedzh5w6ymnoebve74a2a7oezgich25wdh4pdsqmvv3jvpkf@kyk2gz5khibe> <2f1bdd7a-04a0-49a7-b275-4332f2979378@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2f1bdd7a-04a0-49a7-b275-4332f2979378@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bdlmkePB c=1 sm=1 tr=0 ts=69a94745 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=SOEfcho8Kit_SEfO-KEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: yQapzVpZ0AWdDT2bYD27ENEcOfHrUF7F X-Proofpoint-ORIG-GUID: yQapzVpZ0AWdDT2bYD27ENEcOfHrUF7F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA3MiBTYWx0ZWRfX1mqjUdvduvzQ JzBikQW7czHKcftml3QnH6Zk2WCWnTHZc4h+FgqOeL3wAnvdrrV0ERltYeQ6qsbrv4l4ESXJmqp 2O8lTLNSRGNqrxc1uQOxSs1vNyoL4r8bq1wUTsCADY48sfsSEDVGdj+gQ9eHOBnQTBvMQ0L6Npd 28S0dz5fuPVmgA2SCeltyzKkY4KdcI10dT01ox03iU8afnXqw5W8DyS6UcmWjWLVm41jvfqtUn7 hDprlxVpQUbCcn0RBNdda505FXpcEYm5CnMCuyt94W79zbLfAx0yLRwwUTiUMSbXe0EXtUB9jpU rIhl9WJ2WEaje4S7ceyK+ROEYmOwMDSJFj9/SzWTUDoOG1bi/KJiyite2gMthTFXqNVJ4HKtLCc JWxhlWrtRvbcd430wMNIdVj5zdi5G19GPYkD4TUIaq7eTnR2RmKYwO+7fjZCZPjLKyhrPsoEcMI GRKeke/LzVzrrE8CSwA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050072 On 3/5/26 3:18 AM, Bryan O'Donoghue wrote: > On 05/03/2026 00:33, Dmitry Baryshkov wrote: >> I've cross-checked this against X1E80100 driver. The main changes are a >> drop of IFE_1, SPE_0, and two PLLs. However it also: >> - uses hw_clk_ctrl for several clocks >> - uses rcg2_shared_ops instead of rcg2_ops for several clocks >> - uses hwcg_reg and BRANCH_HALT_VOTED for cam_cc_camnoc_axi_nrt_clk >> - uses HW_CTRL_TRIGGER for cam_cc_bps_gdsc and cam_cc_ipe_0_gdsc >> - uses non-AO clock for cam_cc_xo_clk_src >> >> Are all these changes expected? Are any of them also applicable to X1E? >> >> At this point, I'm torn between suggesting the merge of this driver into >> X1E driver and ack'ing the current form. > > We can test the diff but, I'm not sure that will really answer the question if it is the right-thing-to-do. > > OTOH if it ain't broke, don't fix it. > > Reverse the question - is there any reason to have this driver at all ? Can the x1e CAMCC be used as-is ? > > If not, then we can accept this patch and potentially look at merging the two drivers later on. > > I assume the code submitted has a purpose though i.e. its not possible to just use Hamoa and Purwa interchangably. > > A few community members showed me CAMSS working on Purwa last year in Amsterdam with the x1e code - one error if I recall was a clock splat. > > So superficially it adds up to me that its not a 1:1 thing with these two parts. The difference between 'can/does it work in some simple use case' vs 'is it correct' is that the exact match for clock configurations between H and P is (according to the computer) 4 clocks (out of 200+ in the camcc topology). Most of the changes are small differences in frequency steps or which PLL is used for a given OPP etc, which ends up being small in the Linux representation of that data since many of the freq tables are reused 3, 4, 5 times and many clocks (branches) don't even feature one. I would imagine almost all of the points raised by Dmitry probably apply (but I'll let the people in the know comment on that), which would greatly reduce the effective diff. If they do, the drivers could indeed be merged since the delta would be just those couple freq tables and NULLifying 13 clocks on Purwa Konrad