From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934860AbdBQTte (ORCPT ); Fri, 17 Feb 2017 14:49:34 -0500 Received: from webczatnet.pl ([91.121.100.5]:51980 "EHLO webczatnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755769AbdBQTtd (ORCPT ); Fri, 17 Feb 2017 14:49:33 -0500 Subject: Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init To: Kevin Hilman References: <20170216145222.1577-1-webczat@webczatnet.pl> <20170216145222.1577-2-webczat@webczatnet.pl> Cc: Carlo Caione , Ulf Hansson , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Micha=c5=82_Zegan?= Message-ID: Date: Fri, 17 Feb 2017 20:49:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 17.02.2017 o 20:44, Kevin Hilman pisze: > Michał Zegan writes: > >> At the end of function meson_mmc_clk_init, the cfg_div clock was >> prepared, enabled and configured, but then immediately disabled due to bogus if statements. >> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning. >> Fix that by changing the code to disable clock only when it failed to be configured. >> >> Signed-off-by: Michał Zegan > I believe this one is not needed any more after Heiner's cleanups? I think it is not needed, yes. > > Kevin