From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936485AbcIVUPL (ORCPT ); Thu, 22 Sep 2016 16:15:11 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34262 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932181AbcIVUPI (ORCPT ); Thu, 22 Sep 2016 16:15:08 -0400 Subject: Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue To: =?UTF-8?Q?Antti_Ker=c3=a4nen?= References: <20160922151758.GB3565@kroah.com> <20160922155924.13299-1-detegr@gmail.com> Cc: sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, bhaktipriya96@gmail.com, yudongbin@hisilicon.com, puck.chen@hisilicon.com, weiyongjun1@huawei.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: Date: Thu, 22 Sep 2016 13:15:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160922155924.13299-1-detegr@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2016 08:59 AM, Antti Keränen wrote: > Remove unnecessary braces surrounding a single statement block > In the future, when sending different versions of a patch please give a short summary of what's changed. I think this is just a resend from v2 with more reviewers added but I'm not 100% sure. > Signed-off-by: Antti Keränen > --- You can put your summary right here between the --- and the diffstat. > drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > index 659aa71..bd45151 100644 > --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c > +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > @@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev) > > ipdev = platform_get_drvdata(pdev); > > - for (i = 0; i < ipdev->data->nr; i++) { > + for (i = 0; i < ipdev->data->nr; i++) > ion_heap_destroy(ipdev->heaps[i]); > - } > + > ion_destroy_platform_data(ipdev->data); > ion_device_destroy(ipdev->idev); > > The patch looks fine though so assuming nothing else has changed Acked-by: Laura Abbott