From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426E3C001B0 for ; Tue, 15 Aug 2023 01:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233789AbjHOBQj (ORCPT ); Mon, 14 Aug 2023 21:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbjHOBQO (ORCPT ); Mon, 14 Aug 2023 21:16:14 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 848D31715; Mon, 14 Aug 2023 18:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vmDqYNYNVKX9nXI+lnVpwoCYe/6hDlYjcGo/oG9uNZw=; b=pU6w/PiTHnSopHqx4VBIZ9YE+K Peh6KOzMWxCwpjUPzVboVRk8HlCIt2ia5B6yapuSphNtOBHySbIuXH8+Ck36sg805kKE269OThiNM Ix5oCOPg0FWwvm2s1NyFG9V9jsvzdpjAEjlhLdteBO3EPw7tUlIqCX3eAAWld1wlTXrA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qVifD-0046d9-ES; Tue, 15 Aug 2023 03:16:03 +0200 Date: Tue, 15 Aug 2023 03:16:03 +0200 From: Andrew Lunn To: Alfred Lee Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, sgarzare@redhat.com, AVKrasnov@sberdevices.ru Subject: Re: [PATCH net v3] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset Message-ID: References: <20230815001323.24739-1-l00g33k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230815001323.24739-1-l00g33k@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 05:13:23PM -0700, Alfred Lee wrote: > If the switch is reset during active EEPROM transactions, as in > just after an SoC reset after power up, the I2C bus transaction > may be cut short leaving the EEPROM internal I2C state machine > in the wrong state. When the switch is reset again, the bad > state machine state may result in data being read from the wrong > memory location causing the switch to enter unexpected mode > rendering it inoperational. Hi Alfred It is normal to place a history after the --- of what changed between each version. > Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset") > Signed-off-by: Alfred Lee Reviewed-by: Andrew Lunn Andrew