From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A10C432C3 for ; Thu, 14 Nov 2019 11:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7546206DC for ; Thu, 14 Nov 2019 11:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="XzKnS/Zl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbfKNLYy (ORCPT ); Thu, 14 Nov 2019 06:24:54 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34744 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfKNLYy (ORCPT ); Thu, 14 Nov 2019 06:24:54 -0500 Received: by mail-wm1-f68.google.com with SMTP id j18so7223350wmk.1 for ; Thu, 14 Nov 2019 03:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=M7cm+fLydaE7vlZimi8Trm6gsX1LXO9Kv4DMDE9E2a4=; b=XzKnS/ZlZ5mnyKPhJ3ZRsgZJx3bd8m1dDrS+3vnADo8LkOTj6Jfli87r/jpkrWImiy qHL7W8hjCSvkga9PfWzIiAkzyp+GYg7D8sNx0XQZ7t1ML8LBHgHJrqaAUzVUBJyPgPmK ZPvaGTf0MFtGFQV5goJuoMcGPTH3vdvCuJDhnwZtEZYvDPNkhg007wZBwD2LnFQhmxXJ LDPAwl+zigBI7PfJG144K2G+qK2r+LAdR/RDGdxVwKcDzGR8SqbeBNuvjYDx1C9PCHYs k4S5iycZfMLoUShDmPEku3NSkyRZvOutMMBUXVnY2cYmywj0HJxbVh/+gbsSfNpsLBvE Ji1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=M7cm+fLydaE7vlZimi8Trm6gsX1LXO9Kv4DMDE9E2a4=; b=POUl2KGC3otJ0at94GpW4gKH1SrXju2FiVv/+EjxHUcvez+p8w5vXnIxmPMesubg9x S+uwmI+BF+0SbdHM+uePrUBY0Wg7BIta9FN9IZWkQdyU0ZU040Pq7XkEk1Lp67tl9qhI PNXgugyU0E85iTpzSDquGCIHKGCKqwJK3XJKVCBxvZvfB/PgsApvEhD0AFjqXTz6RZcw XT+H2vDM6zI0TWydc0Hiw2x2fpnUXqirp8eRAzb4g4UAOa8gcFJYpu+Cw88dHT6+h6Bs T0r7rXDGIBS48P2BU32tPQ3kuWYEXYRGkpU+6Zxmi27qORvIdlrI8lO7awwzo/kP4bIH j/LQ== X-Gm-Message-State: APjAAAVtgb+1A3nUKiWgzIWUwM2L3sJ6/tTcZpdAsgxQM1rrwEYdi/1U UqNVq9x3aX6AUtFMX7wkIYXi3tt88n6gXg== X-Google-Smtp-Source: APXvYqwkHaDLIrBB2ahBogSdVlv0JY5yaRiYNBcNunBMV00UbkQodqHpIzZqO/WQFF/MWnMIYUX27A== X-Received: by 2002:a05:600c:cb:: with SMTP id u11mr7280243wmm.5.1573730691206; Thu, 14 Nov 2019 03:24:51 -0800 (PST) Received: from [10.32.51.158] ([185.149.63.251]) by smtp.gmail.com with ESMTPSA id b1sm6346761wrs.74.2019.11.14.03.24.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 03:24:50 -0800 (PST) Subject: Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class definition To: Dan Murphy , jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191104123707.31930-1-dmurphy@ti.com> <20191104123707.31930-5-dmurphy@ti.com> From: Martin Fuzzey Message-ID: Date: Thu, 14 Nov 2019 12:24:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20191104123707.31930-5-dmurphy@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: fr Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 04/11/2019 13:36, Dan Murphy wrote: > +int devm_led_classdev_multicolor_register_ext(struct device *parent, > + struct led_classdev_mc *mcled_cdev, > + struct led_init_data *init_data) > +{ > + struct led_classdev_mc **dr; > + int ret; > + > + dr = devres_alloc(devm_led_classdev_multicolor_release, > + sizeof(*dr), GFP_KERNEL); > + if (!dr) > + return -ENOMEM; > + > + ret = led_classdev_multicolor_register(parent, mcled_cdev); This drops init_data, should be led_classdev_multicolor_register_ex Regards, Martin