From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Hao Luo <haoluo@google.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Song Liu <songliubraving@fb.com>,
Namhyung Kim <namhyung@kernel.org>,
Blake Jones <blakejones@google.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH bpf-next v2] bpf: Cache the last valid build_id.
Date: Fri, 25 Feb 2022 15:43:29 -0500 [thread overview]
Message-ID: <a7f26f93-c5f8-2abc-e186-5d179706ae8e@soleen.com> (raw)
In-Reply-To: <20220224000531.1265030-1-haoluo@google.com>
On 2/23/22 19:05, Hao Luo wrote:
> For binaries that are statically linked, consecutive stack frames are
> likely to be in the same VMA and therefore have the same build id.
> As an optimization for this case, we can cache the previous frame's
> VMA, if the new frame has the same VMA as the previous one, reuse the
> previous one's build id. We are holding the MM locks as reader across
> the entire loop, so we don't need to worry about VMA going away.
>
> Tested through "stacktrace_build_id" and "stacktrace_build_id_nmi" in
> test_progs.
>
> Suggested-by: Greg Thelen <gthelen@google.com>
> Signed-off-by: Hao Luo <haoluo@google.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks,
Pasha
next prev parent reply other threads:[~2022-02-25 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 0:05 Hao Luo
2022-02-24 0:10 ` Andrii Nakryiko
2022-02-24 0:33 ` Hao Luo
2022-02-24 1:10 ` Andrii Nakryiko
2022-02-24 1:11 ` Hao Luo
2022-02-24 2:31 ` Song Liu
2022-02-24 18:13 ` Namhyung Kim
2022-02-25 20:43 ` Pasha Tatashin [this message]
2022-03-11 1:16 ` Hao Luo
2022-03-11 19:11 ` Andrii Nakryiko
2022-02-28 17:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7f26f93-c5f8-2abc-e186-5d179706ae8e@soleen.com \
--to=pasha.tatashin@soleen.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=blakejones@google.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gthelen@google.com \
--cc=haoluo@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®