From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26E2540EB9D for ; Mon, 27 Jul 2026 13:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785158226; cv=none; b=PKvE0sJ/ZMTp8dFhvv6Vo6eFtbyRxUtlQoVnIOGdutnpAHVDgzvDClUBgT6OUEpxDxpPccTldfpuKuNoHpPyGzEDs5ckL/S4MKJahicKCAhMn+Vbt8syAGPEvJ9Fb0EpfyR8/1CXTXxiC69O4dJ0KwY5Qix5hHP3la9PINMWKEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785158226; c=relaxed/simple; bh=F96RBXOWe+Z7BfTHXajKMUCB9uGSALudq3DqKwJOc9Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h974gOyWj52FTzDcLQjxL2DssJHox1xqiH0UG6fUH9MH+mkt+4pNKGZUXxcm/RZmoK02NBlrFQEyIUJ1pMVG2t3ze0fHyskQGEQtvQ1IRmFicgncfYTNsx+b5jiLzAZRsoFBTDQ8QBdFTV7CGn3lvjjJBTdr8YXAgkPJDA5qyhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EOVwXt2B; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EOVwXt2B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4CD1F000E9; Mon, 27 Jul 2026 13:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785158224; bh=zdQJhbrsQHteHSYcPe9nSiBD4ItXTowiBtFndGbCnO8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=EOVwXt2BblgCHd+f1rWS50HK1CY5ebCT70jTTiU/Fyi6HFo5Y1FJ9y7UKDNX8x65k Hpj78ABHSjQpCjZoeUSZtt+AslXzwm9jQZxRTTm/5ca6xp8NMHF4QKmZpb/+mXphZp 73aSjtLBGflzKRMCwd2B9cD15A4riTKdpCjasq3T1ZlvUmmDmdJzW89AxwphcIegaw 3Z/VJOoZ9c1j+THr8prCD46I5kKf8vYf0G1y4ir4j+RC7HMfOJE7LP9wygfOaNNKAb HFnGGe3TWcRzfGpVpICnVbNWOwZQVyzLwpSYXr1EOA/VlfUYd5gylXbqnT5mRT1uq+ Eqi1BYPdYLxog== Message-ID: Date: Mon, 27 Jul 2026 15:17:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas() To: Thorsten Blum , Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260712151300.3664-3-thorsten.blum@linux.dev> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260712151300.3664-3-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 12/07/2026 à 17:13, Thorsten Blum a écrit : > The local table structure is not used - remove it. > > Remove % in the comment while at it. > > Signed-off-by: Thorsten Blum Looks like it's never been used since commit de91a5342995 ("[POWERPC] ps3: add spu support") that introduced it. Reviewed-by: Christophe Leroy (CS GROUP) I have no opinion about the %0 versus 0, is it worth the change ? > --- > arch/powerpc/platforms/ps3/spu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c > index e817def7f424..c904f9fa1caa 100644 > --- a/arch/powerpc/platforms/ps3/spu.c > +++ b/arch/powerpc/platforms/ps3/spu.c > @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu) > * The current HV requires the spu shadow regs to be mapped with the > * PTE page protection bits set as read-only. > * > - * Returns: %0 on success or -errno on error. > + * Returns: 0 on success or -errno on error. > */ > > static int __init setup_areas(struct spu *spu) > { > - struct table {char* name; unsigned long addr; unsigned long size;}; > - > spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr, > sizeof(struct spe_shadow), > pgprot_noncached_wc(PAGE_KERNEL_RO));