mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Scally <dan.scally@ideasonboard.com>
To: Oliver Neukum <oneukum@suse.com>,
	mchehab@kernel.org, bryan.odonoghue@linaro.org,
	dan.scally+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se, hverkuil+cisco@kernel.org,
	deepa.madivalara@oss.qualcomm.com, entropy1110@gmail.com,
	jai.luthra+renesas@ideasonboard.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4L: core: ioctl: fix format description for V4L2_PIX_FMT_RAW_CRU20
Date: Mon, 16 Nov 2026 14:45:20 +0000	[thread overview]
Message-ID: <a7f7c29d-dfda-48ed-8790-2b86eaa1b909@ideasonboard.com> (raw)
In-Reply-To: <20261116143716.602898-1-oneukum@suse.com>

Hi Oliver

On 16/11/2026 14:37, Oliver Neukum wrote:
> The description for the 20bit format says 14bit.
> Likely copy'n'paste. Change it to 20.
> 
> Fixes: 78584431e2ce ("media: v4l2: Add Renesas Camera Receiver Unit pixel formats")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---

Oops! Thanks for spotting that!

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 17ba1ae70735..fe9dac613e92 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1434,7 +1434,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>   	case V4L2_PIX_FMT_SGBRG16:	descr = "16-bit Bayer GBGB/RGRG"; break;
>   	case V4L2_PIX_FMT_SGRBG16:	descr = "16-bit Bayer GRGR/BGBG"; break;
>   	case V4L2_PIX_FMT_SRGGB16:	descr = "16-bit Bayer RGRG/GBGB"; break;
> -	case V4L2_PIX_FMT_RAW_CRU20:	descr = "14-bit Raw CRU Packed"; break;
> +	case V4L2_PIX_FMT_RAW_CRU20:	descr = "20-bit Raw CRU Packed"; break;
>   	case V4L2_PIX_FMT_SN9C20X_I420:	descr = "GSPCA SN9C20X I420"; break;
>   	case V4L2_PIX_FMT_SPCA501:	descr = "GSPCA SPCA501"; break;
>   	case V4L2_PIX_FMT_SPCA505:	descr = "GSPCA SPCA505"; break;


      reply	other threads:[~2026-11-16 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:37 Oliver Neukum
2026-11-16 14:45 ` Dan Scally [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7f7c29d-dfda-48ed-8790-2b86eaa1b909@ideasonboard.com \
    --to=dan.scally@ideasonboard.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=dan.scally+renesas@ideasonboard.com \
    --cc=deepa.madivalara@oss.qualcomm.com \
    --cc=entropy1110@gmail.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jai.luthra+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®