From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05D22137C2D; Tue, 27 Feb 2024 10:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028332; cv=none; b=ScFa1hF1s7DwMmUxlPkR238mPep3x6nCsZ58mmqan5Wczj2ypYlb4wQWUpyXG+ckzy5DQFWiuPEAusrvu0YT82S/Bv7g1Dqu4woK+Db0T256QmixAXL/WY+OCr1JJfycXrVvv/tvywIyeLEBYx05aKcVhVmhOrRrq9FRqIJY2Ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028332; c=relaxed/simple; bh=qTKCh/UYun8MIHt+3k9VcP0gbTE3xP+PfI30BTgmONg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KzPKw0nKLDvS/hkVIoTW0KQoYzOBXSybv3oxrSzeuOZXYF9pbH9oKoyyBOw0AFest8oA8OMf1tOR+1BXOzSi5gmg6ysaqDxIQvZVmqXuH3JoIRcZSvdDmmLlU+iW8lyVx/7eCLdhVH5mHXZxD+ltKUVUE/hPj0lnvcOFpbGOyvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=soi8/goX; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=oqhTd1iM; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=soi8/goX; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=oqhTd1iM; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="soi8/goX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="oqhTd1iM"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="soi8/goX"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="oqhTd1iM" Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2853E226E8; Tue, 27 Feb 2024 10:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=soi8/goXCUpmlv19LLto6jAlcz8JoEvm1nZpGgqTSTtPbqneegXav+HzwbxK++hleQ9qCj 3k6rRD9ScpgXGEc76aF2PnpvxqqgNu3BOaYXNc7mqXUOKGqmHaQMHFCC9KBlog2uVCvWC3 /QfGbsbvbpNxNVi4ztfU9W6hGk0OshM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=oqhTd1iMyjfXSwqjHSZv10e9xCjuScPkIxVR+BErjIYgTHsvgvdHni1yXcYrAS6McMvw+h JC4OhYkBuLdaFZAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=soi8/goXCUpmlv19LLto6jAlcz8JoEvm1nZpGgqTSTtPbqneegXav+HzwbxK++hleQ9qCj 3k6rRD9ScpgXGEc76aF2PnpvxqqgNu3BOaYXNc7mqXUOKGqmHaQMHFCC9KBlog2uVCvWC3 /QfGbsbvbpNxNVi4ztfU9W6hGk0OshM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=oqhTd1iMyjfXSwqjHSZv10e9xCjuScPkIxVR+BErjIYgTHsvgvdHni1yXcYrAS6McMvw+h JC4OhYkBuLdaFZAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 9943913216; Tue, 27 Feb 2024 10:05:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id OsmhHeez3WWzOgAAn2gu4w (envelope-from ); Tue, 27 Feb 2024 10:05:27 +0000 Message-ID: Date: Tue, 27 Feb 2024 11:05:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers Content-Language: en-US To: Alice Ryhl Cc: Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-1-d821250204a6@google.com> From: =?UTF-8?Q?Carlos_L=C3=B3pez?= In-Reply-To: <20240208-alice-mm-v2-1-d821250204a6@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.29 X-Spamd-Result: default: False [-1.29 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,protonmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_MATCH_FROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLx931z8whuiu5x894fnbjwz7n)]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; BAYES_HAM(-1.50)[91.72%]; RCPT_COUNT_TWELVE(0.00)[24]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linuxfoundation.org,android.com,joelfernandes.org,google.com,arndb.de,kvack.org,vger.kernel.org,kernel.org,gmail.com,garyguo.net,protonmail.com,proton.me,samsung.com,chromium.org,zeniv.linux.org.uk,linux-foundation.org]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Flag: NO On 8/2/24 16:47, Alice Ryhl wrote: > + /// Create a reader that can access the same range of data. > + /// > + /// Reading from the clone does not advance the current reader. > + /// > + /// The caller should take care to not introduce TOCTOU issues, as described > + /// in the documentation for [`UserSlice`]. > + pub fn clone_reader(&self) -> UserSliceReader { > + UserSliceReader { > + ptr: self.ptr, > + length: self.length, > + } > + } Just out of curiosity, is there any reason why this is not implemented in terms of the Clone trait? -- Carlos López Security Engineer SUSE Software Solutions