mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andy Lutomirski" <luto@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"the arch/x86 maintainers" <x86@kernel.org>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Kees Cook" <kees@kernel.org>, "Xin Li" <xin@zytor.com>,
	"Ahmed S. Darwish" <darwi@linutronix.de>,
	"Sohil Mehta" <sohil.mehta@intel.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Jens Axboe" <axboe@kernel.dk>
Subject: Re: [PATCH v2 0/3] x86/fred: enable FRED by default
Date: Thu, 26 Mar 2026 15:11:19 -0700	[thread overview]
Message-ID: <a7faee54-e13e-4403-be60-abbbc77978e0@app.fastmail.com> (raw)
In-Reply-To: <20260325230151.1898287-1-hpa@zytor.com>



On Wed, Mar 25, 2026, at 4:01 PM, H. Peter Anvin wrote:
> From: H. Peter Anvin (Intel) <hpa@zytor.com>
>
> When FRED was added to the mainline kernel, it was set up as an
> explicit opt-in due to the risk of regressions before hardware was
> available publicly.
>
> Now, Panther Lake (Core Ultra 300 series) has been released, and
> benchmarking by Phoronix has shown that it provides a significant
> performance benefit on most workloads:
>
>     https://www.phoronix.com/review/intel-fred-panther-lake

Those performance increases while with fio / io_uring are ridiculous.  I wonder whether anyone can looked at /proc/interrupts to try to figure out what's going on.  I imagine we're bottlenecking on IO interrupts or something and FRED speeds that up by a factor of several, but this makes me wonder whether there's some tuning that should be done.

Jens, for background, FRED ought to speed up page faults and interrupts (both IPI and device) by a considerable amount -- maybe a reduction of 20k or more cycles per interrupt.  But Phoronix is showing up to a factor of 2 (!) actual performance increase using io_uring with a job count of 8.  Now maybe 8 is too small, but I'm wondering whether the io_uring or IO part is missing some optimization that it ought to have.

--Andy

  parent reply	other threads:[~2026-03-26 22:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 23:01 H. Peter Anvin
2026-03-25 23:01 ` [PATCH v2 1/3] " H. Peter Anvin
2026-03-26  2:04   ` Sohil Mehta
2026-03-30 10:23   ` [tip: x86/fred] x86/fred: Enable " tip-bot2 for H. Peter Anvin
2026-03-25 23:01 ` [PATCH v2 2/3] x86/Kconfig: tighten up wording of the CONFIG_X86_FRED help text H. Peter Anvin
2026-03-26 16:26   ` Borislav Petkov
2026-03-25 23:01 ` [PATCH v2 3/3] x86/fred: Remove kernel log message when initializing exceptions H. Peter Anvin
2026-03-30 10:23   ` [tip: x86/fred] " tip-bot2 for Sohil Mehta
2026-03-26 22:11 ` Andy Lutomirski [this message]
2026-03-26 22:26   ` [PATCH v2 0/3] x86/fred: enable FRED by default Jens Axboe
2026-03-28  1:20   ` H. Peter Anvin
2026-04-03 15:29     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7faee54-e13e-4403-be60-abbbc77978e0@app.fastmail.com \
    --to=luto@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bp@alien8.de \
    --cc=darwi@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox