From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA0425EF8A for ; Tue, 25 Feb 2025 11:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740482582; cv=none; b=iertirOiHMt2RIu88bb48Yur3p1ti7eUOqPpFBeC0euGu91l63bDU7IJDcxbf9BMrLNpiDi2VPacbCk1fHQC2JWmz48GmKKUy35haK1cdKf16p02MY21zbkxd4YuBS2lrJimtuz4Zz5Cpuo4NNOZ5EGeyB9+aUz5QiO2omGzxak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740482582; c=relaxed/simple; bh=IdS51EqrwhQGXKi0be7/qr+gerlcZGci2nltgQ5QF0Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UBh8ZXpxfnjPcgulWHOr+gq2/7Dsx2utyTmVNGZmpCvRIWbEx9wJNjIO8JugKd6bgTuBk2QEruOtzY9aG8IPs0Pr7QJX+kXzoFjYEtu7lvt4P4Ran6rAoFp38TqQPqBAK/+UO5BRL4Cfldjd0o5ncM8jovfmT+T15K/Ug5lWA9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=kZE36igP; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="kZE36igP" Received: by mail.gandi.net (Postfix) with ESMTPSA id 4EC7B204D8; Tue, 25 Feb 2025 11:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740482578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ibjw3glGo7gZbGP++8SpLwbaeMIUYX8JsdvCHIT+woE=; b=kZE36igPtVuqJXk2W1P57OgdXA/Oh1S9drcZgxHUDE1DV9192fyEbedirxJmhrInvc59XN 5StiXlafjI+2YJa6aeF21FrlVynSbD/6KLI8uGYo4yRkiMNeSLd6qEcTasuhx7fYp/1u2o e8k/JaBTJ292EbNbAFZrt6lsgOYnWNPWaa0UVBr8M/2qrFOxt0OXF0fxpfe24U8nl54Pxb IpzKceu1rWMYVHMDLzunqLGPsiMNhVhF0xEtPr30xltflQaO9bEEewMHbTy1SsYBj9mv+r nMfG4l92KorHZWRSAXeiTgPFj5D6mlZrTBKOtaKiJ+I3GjDFgLTjW001kOoKeg== Date: Tue, 25 Feb 2025 12:22:56 +0100 From: Louis Chauvet To: Jim Cromie , linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: Re: [PATCH 03/63] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Message-ID: Mail-Followup-To: Jim Cromie , linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com References: <20250125064619.8305-1-jim.cromie@gmail.com> <20250125064619.8305-4-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250125064619.8305-4-jim.cromie@gmail.com> X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekudehjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnohhuihhsucevhhgruhhvvghtuceolhhouhhishdrtghhrghuvhgvthessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepudeiffduffeivdejgfejheeuudekkedvjeeuffegfefghfffkeelgffgieevudejnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohhuihhsqdgthhgruhhvvghtqdhlrghpthhophdpmhgrihhlfhhrohhmpehlohhuihhsrdgthhgruhhvvghtsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedugedprhgtphhtthhopehjihhmrdgtrhhomhhivgesghhmrghilhdrtghomhdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehjsggrrhhonhesrghkrghmrghirdgtohhmpdhrtghpthhtohepghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnr dhorhhgpdhrtghpthhtohepuhhkrghsiigssegthhhrohhmihhumhdrohhrghdprhgtphhtthhopehinhhtvghlqdhgfhigqdhtrhihsghotheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthhopegurhhiqdguvghvvghlsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtoheprghmugdqghhfgieslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh X-GND-Sasl: louis.chauvet@bootlin.com Le 25/01/2025 à 07:45, Jim Cromie a écrit : > When a dyndbg classname is unknown to a kernel module (as before > previous patch), the callsite is un-addressable via >control queries. > > The control-file displays this condition as "class unknown," > currently. That spelling is sub-optimal/too-generic, so change it to > "class:_UNKNOWN_" to loudly announce the erroneous situation, and to > make it exceedingly greppable. > > NB: pr_debugs are only alterable via >control, and to protect class'd > debug's from unintended alteration, "class name" must be given to > change them. Classmaps map known classes to reserved .class_ids (the > 1..64 val range per module). > > Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet > --- > lib/dynamic_debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > index 5a007952f7f2..147540c57154 100644 > --- a/lib/dynamic_debug.c > +++ b/lib/dynamic_debug.c > @@ -1154,7 +1154,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p) > if (class) > seq_printf(m, " class:%s", class); > else > - seq_printf(m, " class unknown, _id:%d", dp->class_id); > + seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id); > } > seq_putc(m, '\n'); > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com