From: David Lechner <dlechner@baylibre.com>
To: Alexandru Ardelean <aardelean@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
lars@metafoo.de, michael.hennerich@analog.com,
gstols@baylibre.com
Subject: Re: [PATCH v4 2/8] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct()
Date: Thu, 5 Sep 2024 16:37:17 -0500 [thread overview]
Message-ID: <a7fd7490-53c9-4a25-a659-6f52ff509fe8@baylibre.com> (raw)
In-Reply-To: <20240905082404.119022-3-aardelean@baylibre.com>
On 9/5/24 3:23 AM, Alexandru Ardelean wrote:
> The ad7606_scan_direct() function returns 'int', which is fine for 16-bit
> samples.
> But when going to 18-bit samples, these need to be implemented as 32-bit
> (or int) type.
>
> In that case when getting samples (which can be negative), we'd get random
> error codes.
> So, the easiest thing is to just move the 'val' pointer to
> 'ad7606_scan_direct()'. This doesn't qualify as a fix, it's just a
> preparation for 18-bit ADCs (of the AD7606 family).
>
> Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
> ---
Reviewed-by: David Lechner <dlechner@baylibre.com>
next prev parent reply other threads:[~2024-09-05 21:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 8:23 [PATCH v4 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-05 8:23 ` [PATCH v4 1/8] iio: adc: ad7606: add 'bits' parameter to channels macros Alexandru Ardelean
2024-09-05 21:25 ` David Lechner
2024-09-06 5:10 ` Alexandru Ardelean
2024-09-05 8:23 ` [PATCH v4 2/8] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() Alexandru Ardelean
2024-09-05 21:37 ` David Lechner [this message]
2024-09-05 8:23 ` [PATCH v4 3/8] iio: adc: ad7606: split a 'ad7606_sw_mode_setup()' from probe Alexandru Ardelean
2024-09-05 8:23 ` [PATCH v4 4/8] iio: adc: ad7606: wrap channel ranges & scales into struct Alexandru Ardelean
2024-09-05 8:23 ` [PATCH v4 5/8] iio: adc: ad7606: rework available attributes for SW channels Alexandru Ardelean
2024-09-05 8:24 ` [PATCH v4 6/8] dt-bindings: iio: adc: document diff-channels corner case for some ADCs Alexandru Ardelean
2024-09-05 8:24 ` [PATCH v4 7/8] dt-bindings: iio: adc: add docs for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-05 8:27 ` Krzysztof Kozlowski
2024-09-05 21:54 ` David Lechner
2024-09-07 4:59 ` Alexandru Ardelean
2024-09-07 14:09 ` David Lechner
2024-09-07 17:57 ` Alexandru Ardelean
2024-09-05 22:02 ` David Lechner
2024-09-07 5:01 ` Alexandru Ardelean
2024-09-05 8:24 ` [PATCH v4 8/8] iio: adc: ad7606: add support " Alexandru Ardelean
2024-09-05 23:30 ` David Lechner
2024-09-06 5:34 ` Alexandru Ardelean
2024-09-06 13:33 ` David Lechner
2024-09-06 14:03 ` Alexandru Ardelean
2024-09-07 6:02 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7fd7490-53c9-4a25-a659-6f52ff509fe8@baylibre.com \
--to=dlechner@baylibre.com \
--cc=aardelean@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=gstols@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®