mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nam Cao <namcao@linutronix.de>
Cc: apw@canonical.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: add "Reported-and-tested-by:" tag
Date: Fri, 19 Apr 2024 15:06:11 -0700	[thread overview]
Message-ID: <a8094ffbabd308752cb02cd1c1d5b67c@perches.com> (raw)
In-Reply-To: <20240419191957.42396-1-namcao@linutronix.de>

On 2024-04-19 12:19, Nam Cao wrote:
> The tag "Reported-and-tested-by:" is used all the time. Add this tag.
> 
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..ff44720fcf23 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
>  	Tested-by:|
>  	Reviewed-by:|
>  	Reported-by:|
> +	Reported-and-tested-by:|
>  	Suggested-by:|
>  	To:|
>  	Cc:
> @@ -712,7 +713,7 @@ sub find_standard_signature {
>  	my ($sign_off) = @_;
>  	my @standard_signature_tags = (
>  		'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
> -		'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
> +		'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 
> 'Reported-and-tested-by'

Missing a colon
>  	);
>  	foreach my $signature (@standard_signature_tags) {
>  		return $signature if (get_edit_distance($sign_off, $signature) <= 
> 2);

      reply	other threads:[~2024-04-19 22:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 19:19 Nam Cao
2024-04-19 22:06 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8094ffbabd308752cb02cd1c1d5b67c@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=namcao@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®