From: Jens Axboe <axboe@kernel.dk>
To: Rajeev Mishra <rajeevm@hpe.com>, yukuai1@huaweicloud.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: fixed commit message
Date: Mon, 18 Aug 2025 13:07:41 -0600 [thread overview]
Message-ID: <a8097b4d-cbae-417b-9608-a3512d66f8d3@kernel.dk> (raw)
In-Reply-To: <20250818184821.115033-1-rajeevm@hpe.com>
On 8/18/25 12:48 PM, Rajeev Mishra wrote:
> fixed the commit message
Still leaves something to be desired - a nit is the line length,
but most in terms of why the change is necessary. At least the
comment in the code explains why this is a needed change, but
the commit message is pretty vague.
I'll fix them up and re-add Yu's review.
--
Jens Axboe
next prev parent reply other threads:[~2025-08-18 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 18:48 Rajeev Mishra
2025-08-18 18:48 ` [PATCH v4 1/2] loop: Consolidate size calculation logic into lo_calculate_size() Rajeev Mishra
2025-08-18 18:48 ` [PATCH v4 2/2] loop: use vfs_getattr_nosec for accurate file size Rajeev Mishra
2025-08-18 19:07 ` Jens Axboe [this message]
2025-08-18 19:10 ` fixed commit message Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8097b4d-cbae-417b-9608-a3512d66f8d3@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajeevm@hpe.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®