From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA04C43382 for ; Tue, 25 Sep 2018 00:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42A502145D for ; Tue, 25 Sep 2018 00:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="zMtXb4WF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42A502145D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbeIYGaY (ORCPT ); Tue, 25 Sep 2018 02:30:24 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:48460 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728343AbeIYGaX (ORCPT ); Tue, 25 Sep 2018 02:30:23 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8P0PWM2029207; Mon, 24 Sep 2018 19:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1537835132; bh=c7eNSBT81Do5FtjhjAP51abYHiK3AxWqxvt5RiL02HU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=zMtXb4WFMan8JLKjlkS3v4xT5TayYD6tv4+iPjITsWPWL9/G36/s4p699quBPp2Rm 7EO7ftUKW3TdDuo+kvuaYzwGYlNDeB7WX5nbpqMDJbtfQOxxL33N2ZAtoyvSYMOnCq kU1dme8wlecJ6VZd55FrA1guLuk/o5GujAvy1qvk= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8P0PW4T029844; Mon, 24 Sep 2018 19:25:32 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 24 Sep 2018 19:25:32 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Mon, 24 Sep 2018 19:25:32 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8P0PV3w029955; Mon, 24 Sep 2018 19:25:31 -0500 Subject: Re: [PATCH] rpmsg: core: add support to power domains for devices To: Srinivas Kandagatla , , CC: , , , Loic Pallardy , Arnaud POULIQUEN References: <20180615095939.1331-1-srinivas.kandagatla@linaro.org> From: Suman Anna Message-ID: Date: Mon, 24 Sep 2018 19:25:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180615095939.1331-1-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: > Some of the rpmsg devices need to switch on power domains to communicate > with remote processor. For example on Qualcomm DB820c platform LPASS > power domain needs to switched on for any kind of audio services. > This patch adds the missing power domain support in rpmsg core. > > Without this patch attempting to play audio via QDSP on DB820c would > reboot the system. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/rpmsg/rpmsg_core.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index b714a543a91d..8122807db380 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > > #include "rpmsg_internal.h" > @@ -449,6 +450,10 @@ static int rpmsg_dev_probe(struct device *dev) > struct rpmsg_endpoint *ept = NULL; > int err; > > + err = dev_pm_domain_attach(dev, true); > + if (err) > + goto out; This patch has broken the virtio-rpmsg stack based rpmsg devices. These devices are non-DT and the rpmsg_dev_probe() is now failing with -19 (-ENODEV) error code. Loic, Arnaud, Can one of you double-confirm this behavior on ST platforms as well? The patch came through 4.14.71 stable release and broke our downstream kernels. regards Suman > + > if (rpdrv->callback) { > strncpy(chinfo.name, rpdev->id.name, RPMSG_NAME_SIZE); > chinfo.src = rpdev->src; > @@ -490,6 +495,8 @@ static int rpmsg_dev_remove(struct device *dev) > > rpdrv->remove(rpdev); > > + dev_pm_domain_detach(dev, true); > + > if (rpdev->ept) > rpmsg_destroy_ept(rpdev->ept); > >