From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8EDB14A86; Sat, 17 Feb 2024 23:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708213734; cv=none; b=uTSNVvhH67K+uli1ofBBtQC3BLBQXFp1Y6C/nXXz3irFXqpU2gs48s2hS3V1ugZ1tlipvFeQ5NnC3X0g9dPtkywsMJisl/lXRD+gAyuLpGhrd8838LPeMZia7NWrlsJFg7kLUFAR7U8sLQPjYpg3r7qivO1ocyHWkBVatB/Fmjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708213734; c=relaxed/simple; bh=1g5oK+yNBXpoPw5N07d7muSFkpE6uSYQn/NJNDkMbAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JVfeuBnyn9KRrD98uRK9whytyn1oHL99zffE/3LEBnrYFy0Y1/ow71p0SCbpFZ32ANJFBD3YJxC17v6Ma1HK0J+dDCv1cuMOvAo/m06ZHqbw02LtfRBEmKhePPSQ1MEosgnXXZ7wOj1QRrabC7oojC8qQW0A9nsWVj39xY9WpB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=CPzKeDAm; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="CPzKeDAm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=FMxvckYePbS1jnoZ5oG6Cm4EypY4Dw/pbZjxC0ZP4yU=; b=CPzKeDAmryQgULRVfeg9ZXkTij sV5K4ExtKLQtMWkXBHzzTZujVOaGPUXXKbK1euewjW9lDjsFSr2E4PYT7u1SBA71pkRVI3/BqoQ8P Yt5mKJuEZUeqa8K0hBbIQZ8PE6rcAY9Yy7FYlnkXwYiyuiFMNbNKcJjI+wuUfEVpT7gA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rbUPw-0085vH-Pp; Sun, 18 Feb 2024 00:48:24 +0100 Date: Sun, 18 Feb 2024 00:48:24 +0100 From: Andrew Lunn To: Christian Marangi Cc: Michael Hennerich , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Richard Cochran , Marek =?iso-8859-1?Q?Beh=FAn?= , Daniel Golle , Qingfang Deng , SkyLake Huang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Arun Ramadoss , UNGLinuxDriver@microchip.com, Peter Geis , Frank , Xu Liang , Piergiorgio Beruto , Andrei Botila , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Michal Simek , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Matthias Brugger , AngeloGioacchino Del Regno , Robert Marko , "Russell King (Oracle)" , Vladimir Oltean , David Epping , Harini Katakam , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, rust-for-linux@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next RFC PATCH 0/3] net: phy: detach PHY driver OPs from phy_driver struct Message-ID: References: <20240217194116.8565-1-ansuelsmth@gmail.com> <65d140fb.5d0a0220.81be3.7138@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65d140fb.5d0a0220.81be3.7138@mx.google.com> > Yes, it was done to limit the patch delta, if I had to account for the > tab for each new section we would be in the order of 2000+ changes I > think. > > > > 64 files changed, 737 insertions(+), 291 deletions(-) > > > > These statistics are not good. If you had deleted more lines than you > > added, then maybe it might be an O.K. idea. > > > > Sometimes KISS is best. > > > > Well IMHO these stats are a bit flawed, the additional code is really > just extra check if ops is defined and the new .ops variable in each > phy_driver. > > If you check patch 2 and 3 you can already see some code is removed. Yes, the problem is, it probably needs another 50 patches to remove all the duplication. I have to question, is that really going to happen? Are you going to keep working on this until every driver has its duplicates removed? It probably needs some tooling to help. Something which can decode the object file, and tell you which ops structures are identical. That can then guide you when editing all the PHY drivers. Andrew