From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB06FC433DF for ; Wed, 22 Jul 2020 09:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86FD520729 for ; Wed, 22 Jul 2020 09:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SJDv4Myf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731419AbgGVJcx (ORCPT ); Wed, 22 Jul 2020 05:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbgGVJcx (ORCPT ); Wed, 22 Jul 2020 05:32:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4A13C0619DE for ; Wed, 22 Jul 2020 02:32:52 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 184so1337141wmb.0 for ; Wed, 22 Jul 2020 02:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vwHeqn+GJzfqT5CHnpILDuTc+uk5/83NXLaFNZ81FAQ=; b=SJDv4Myfu5X3zHK+ZO/6qmjypR9DI38Rgn1FDEfoZriY45kXLlNSIHTHaayb97o7Tj AVB1Ooh66VJYwzvW+NqHyeRSkplkbsr3J7TJyNwCLkJ2Ath/oqP3/vatAKAZ3r0dZzI7 9T5d3kG7aV5MEzkr0zK29kX8VDMu+qcj+PKmgoJ7rbnZZTAliolbgxP1NQmcJIAB0qzV qXvozH6KKekeMfKI+j3eZePPuh71BarOqpbBD0+GmaOzF6uWcDOjBLXfrFaLkY/iwSdw SMHaB5HK3+4iBzNk1Wza8n8SXCVf1zJa9fncDbxYka43v0tPapuGYuc396NgYt6lSDTw 45yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vwHeqn+GJzfqT5CHnpILDuTc+uk5/83NXLaFNZ81FAQ=; b=p2RANBVetPD2rp+EH4h3cdrtmrLVxNNl8ZnEMeLUzIA7yRnJOrO+OI+Dxdo7MCUhEl 6MKxBNSBkLzmg5lDxITpK7cG4rVI3Mq8H2xYIDs0AY8pOBm9LPQlmnGE5mYy1piN4Fkk L/VnA8ahhaFbv1ybIiGSrxUTg/fIAStm14gK0tOpGsbYoRCWsnWFeTDywnydyGRCpGYg NM22lFrwYye9/m0YJtiKeHMiWanay3OBkPfwSHo+2w9uLnE+/Ja//x7cPy4ZEKCJTz05 zxdYW1JM8gwg2sZ665nJYEdsqimK0z95bq6MXK8ztXX629Le/BLnZdWys5LHbIU6Ny5B S9Zw== X-Gm-Message-State: AOAM5336aBrz0iaQW2IDA7lqc6/dtexgUdmP1ZZ0xDLrGysukQ5UEC2L oH6ZvWO5sJC3E7Q6vsEds9lDbeIrwMM= X-Google-Smtp-Source: ABdhPJy+YLy8wuuNSuXK5kp8TEQtybRcvNVmXB/t2lxxEDfw5VOpIW+z+1gT7UDISw2IRJ9pa9exiA== X-Received: by 2002:a1c:7d85:: with SMTP id y127mr8112024wmc.181.1595410371197; Wed, 22 Jul 2020 02:32:51 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id w16sm44813847wrg.95.2020.07.22.02.32.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jul 2020 02:32:50 -0700 (PDT) Subject: Re: [PATCH v2 1/1] nvmem: qcom-spmi-sdam: Enable multiple devices To: Guru Das Srinagesh , linux-arm-msm@vger.kernel.org Cc: Subbaraman Narayanamurthy , David Collins , Anirudh Ghayal , Shyam Kumar Thella , linux-kernel@vger.kernel.org References: <1595360761-640-1-git-send-email-gurus@codeaurora.org> From: Srinivas Kandagatla Message-ID: Date: Wed, 22 Jul 2020 10:32:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1595360761-640-1-git-send-email-gurus@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2020 20:46, Guru Das Srinagesh wrote: > Using pdev->id as the nvmem's config ID (which, by default, is > NVMEM_DEVID_NONE) prevents multiple instances of this driver from > probing because of the following error: > > sysfs: cannot create duplicate filename '/bus/nvmem/devices/spmi_sdam' > > Use NVMEM_DEVID_AUTO as the NVMEM config ID to fix the issue. > > Signed-off-by: Guru Das Srinagesh > --- > drivers/nvmem/qcom-spmi-sdam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied thanks, --srini > > diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c > index 8682cda..a72704c 100644 > --- a/drivers/nvmem/qcom-spmi-sdam.c > +++ b/drivers/nvmem/qcom-spmi-sdam.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2017 The Linux Foundation. All rights reserved. > + * Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved. > */ > > #include > @@ -141,7 +141,7 @@ static int sdam_probe(struct platform_device *pdev) > > sdam->sdam_config.dev = &pdev->dev; > sdam->sdam_config.name = "spmi_sdam"; > - sdam->sdam_config.id = pdev->id; > + sdam->sdam_config.id = NVMEM_DEVID_AUTO; > sdam->sdam_config.owner = THIS_MODULE, > sdam->sdam_config.stride = 1; > sdam->sdam_config.word_size = 1; >