mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Eric Anholt <eric@anholt.net>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable
Date: Sun, 14 Jun 2020 14:16:50 +0200	[thread overview]
Message-ID: <a81cacf1-88e5-18d1-9d01-8e8d32f6f0a7@web.de> (raw)

> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments
> the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.

* Can the term “reference count” become relevant also for this commit message
  besides other possible adjustments?

* Can it be nicer to combine proposed updates for this software module
  as a patch series (with a cover letter)?

* Would you like to add the tag “Fixes”?


…
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
…
> @@ -1088,6 +1088,8 @@  static void vc4_dsi_encoder_enable(struct drm_encoder *encoder)
>  		dev_info(&dsi->pdev->dev, "DSI regs after:\n");
>  		drm_print_regset32(&p, &dsi->regset);
>  	}
> +out:
> +	pm_runtime_put(dev);
>  }
…

* Perhaps use the label “put_runtime” instead?

* Do you propose to perform an additional function call always
  (and not only according to failure cases)?

* How do you think about calling the function “pm_runtime_put_noidle”?

Regards,
Markus

             reply	other threads:[~2020-06-14 12:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 12:16 Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-14  6:52 Navid Emamdoost
2020-06-14 12:32 ` Andy Shevchenko
2020-06-14 19:15   ` Navid Emamdoost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a81cacf1-88e5-18d1-9d01-8e8d32f6f0a7@web.de \
    --to=markus.elfring@web.de \
    --cc=airlied@linux.ie \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emamd001@umn.edu \
    --cc=eric@anholt.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=smccaman@umn.edu \
    --cc=wu000273@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®