From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09EC033C188 for ; Wed, 28 Jan 2026 09:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769592547; cv=none; b=Jmt1yCNfZwjGD/kBJ0EhS9zRnzZXRbyB+4TIpxv481nqLOJSHRnUTaelK61wJYTor7nrnqSeawAUwhUTCr5rzOumLD/2z1ZB02GoFxgjxMc7dhGDmO1hTZ+xCQGZj1i0QjK5KfmcJDBFL5MibAcHvuMFZmbuYmJtwOnQ2e93Sjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769592547; c=relaxed/simple; bh=UP+WW7Dc9SoOQ1SJaOin/KlKCDh8HTR0VomQ0nz2Kek=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aJUKdIQCpR3sUousPi9b3E1s3m9ClDbhz/HVFieeTUvBaH0HMR/Fd8psf+PNzqtZIjPdd7i49P+0+Li7D811QDIu8N3890DUBVm22oQS1xT1+NNMSUWb6GVxOkQFqX5Jd3RAwdscp5rQiRv8y8wrYE6iDmcdLT+mkPAiv1OGyWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D9wUPlET; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D9wUPlET" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48039fdc8aeso34861995e9.3 for ; Wed, 28 Jan 2026 01:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769592544; x=1770197344; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UwOcfsfrDBPmMGisp6X+dkj3y6n6qfrea/qIENi+t2I=; b=D9wUPlETXphj9xcQVvMkON8ogRds7Esz1sjCHxbocBwOLUqAva4cKOxjDlah6krmi/ Hw+pb5U0iiOlwz+OgCYAXPnG3S0WlEYN5JOovzaOvTTZcZc2cs+MocwoRKwZCCIB+/DC tTWXZjYzKykfYE+8wukuQjqnP+CNs0znzyPbFVg6OWvP3KWUNw3q+V8Wa4cqoSK8HoYf 3tK2kct/zo4AWA+tBosaRxB5Glc6NT3LxbpA4w3Ofnqnc0STANUs0NYAu5RKJNObyPlA GuxYj22QZIwChwl9beC22vYVtJYo7wOPl1kRrZYxadqGiv4Ku41ucKl1qzXCg95kK4ce YEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769592544; x=1770197344; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UwOcfsfrDBPmMGisp6X+dkj3y6n6qfrea/qIENi+t2I=; b=iGAuMafeYB6kfzl0wzD0x0rGzmhfgTJCJZ5WWXN3qhV/M/RqXpEX1AIJ0n5Uz294lg XDHNz/RGhSB2WdfZ2n+eoAMEdD1UWoND5d8jntNMlJnKrnJOeOmp56tBVYNJeN5XT+DQ /p6IgTabWqWyO397iV+AzpB1/06JToyshxcqo+0BIV6mSoPurfbisgI7tq0e/hJEtRZB /nJPAnkDp9gygrK2J8A27sQE1k1u41DVIzHNFEs5tg0NWAnE1nsX0S2E/BcABQMbMgJO v7eZ2J+ZUypxo44sMwtaAwfe/QJqZQZm7U0IcdSFlaqKhYszNREN569apA5YZhkCjNXq DhaA== X-Forwarded-Encrypted: i=1; AJvYcCVFpsCAivAJJWPJA57/7oQy3A6oQJ7+4XVOWNGZwtsPVJCGJlJLXtV2qXAtRomqF1o1tFGTrXl3qnf++/s=@vger.kernel.org X-Gm-Message-State: AOJu0YyYM8PTX/2mODWwfBZ4PY/IIM2Y5Ck7hxVZphnqYQZhlK2/N+io mmCkcMWGhiC5oZichLOMDNlA0R/b2MG5jbjFKH6EOojDngxpU5JPVNr3 X-Gm-Gg: AZuq6aLBHFjfG8hV1QW3JapgLwOuKgB30+SVf3042v/Dul3WzQl5YFIOBqLsyJfgFS5 roRpmqBFZ1QYso+w5yS/k6Ewnika5G+FKmhsSkCCJiOrQTIQqpOvkcaIojBFccAW0iLlgUCuGmP yukB/dhOBU2/6zUs+coRlIYOmA3yh9s8ENnuWn4XpYFJRBVxzw0ct48GWORE4qOB+CRWE69MA1G iklLlCRBsPld3vwrJ/6HC7oWh2q/VQq+IfUjhYW+rWmtfJfnk4MmBFOmdAk92EMvT4WAy9ZG52S f0gUjKWKYLK6TBBPXE7FE1YTzM23zZLfr/ID+/j4cU8RD6nx9zm4s6iNNS5XNqnI8liVEVvnXrx 505njQW7++E6fqkyASpdZYt20MdHe3JhGERYJal1mqll7sH06B8NsjMDQVpC8kteMKRImQyQKZ7 UlmlRlYE/b6dq/3rR2G2g= X-Received: by 2002:a05:600c:458a:b0:47b:e2a9:2bd7 with SMTP id 5b1f17b1804b1-48069c6970fmr52404085e9.19.1769592544055; Wed, 28 Jan 2026 01:29:04 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm129275515e9.9.2026.01.28.01.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 01:29:03 -0800 (PST) Message-ID: Subject: Re: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32_array From: Nuno =?ISO-8859-1?Q?S=E1?= To: Chen Ni , haibo.chen@nxp.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: linux-iio@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Date: Wed, 28 Jan 2026 09:29:47 +0000 In-Reply-To: <20260128042700.2260803-1-nichen@iscas.ac.cn> References: <20260128042700.2260803-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-01-28 at 12:27 +0800, Chen Ni wrote: > Add check for the return value of device_property_read_u32_array() and > return the error if it fails in order to catch the error. >=20 > Signed-off-by: Chen Ni > --- > =C2=A0drivers/iio/adc/vf610_adc.c | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c > index d7182ed0d2a7..d53723ccc5b2 100644 > --- a/drivers/iio/adc/vf610_adc.c > +++ b/drivers/iio/adc/vf610_adc.c > @@ -871,7 +871,10 @@ static int vf610_adc_probe(struct platform_device *p= dev) > =C2=A0 > =C2=A0 info->vref_uv =3D regulator_get_voltage(info->vref); > =C2=A0 > - device_property_read_u32_array(dev, "fsl,adck-max-frequency", info->max= _adck_rate, 3); > + ret =3D device_property_read_u32_array(dev, "fsl,adck-max-frequency", > + =C2=A0=C2=A0=C2=A0=C2=A0 info->max_adck_rate, 3); > + if (ret) > + return ret; As Andy pointed out, this is changing behavior so it needs to be properly j= ustified. Also since we are here, maybe use ARRAY_SIZE(info->max_adck_rate). - Nuno S=C3=A1 > =C2=A0 > =C2=A0 info->adc_feature.default_sample_time =3D DEFAULT_SAMPLE_TIME; > =C2=A0 device_property_read_u32(dev, "min-sample-time", &info->adc_featur= e.default_sample_time);