From: "Raphaël Gallais-Pou" <rgallaispou@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Hui Pu <Hui.Pu@gehealthcare.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/bridge: add warning for bridges attached without being added
Date: Sat, 18 Oct 2025 14:46:50 +0200 [thread overview]
Message-ID: <a822d284-f2a2-40f8-987a-6e2f70a22fcf@gmail.com> (raw)
In-Reply-To: <20251003-b4-drm-bridge-alloc-add-before-attach-v1-4-92fb40d27704@bootlin.com>
Le 03/10/2025 à 10:59, Luca Ceresoli a écrit :
> DRM bridges must be added before they are attached. Add a warning to catch
> violations.
>
> The warning is based on the bridge not being part of any list, so it will
> trigger if the bridge is being attached without ever having been added.
>
> It won't catch cases of bridges attached after having been added and then
> removed, because in that case the bridge will be in
> bridge_lingering_list. However such a case is both more demanding to detect
> and less likely to happen, so it can be left unchecked, at least for now.
>
> Link: https://lore.kernel.org/all/20250709-sophisticated-loon-of-rain-6ccdd8@houat/
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
Reviewed-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
Best regards,
Raphaël>
next prev parent reply other threads:[~2025-10-18 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 8:59 [PATCH 0/4] drm/bridge: enforce drm_bridge_add() before drm_bridge_attach() Luca Ceresoli
2025-10-03 8:59 ` [PATCH 1/4] drm/sti: hda: add bridge before attaching Luca Ceresoli
2025-10-18 12:46 ` Raphaël Gallais-Pou
2025-10-03 8:59 ` [PATCH 2/4] drm/sti: hdmi: " Luca Ceresoli
2025-10-18 12:46 ` Raphaël Gallais-Pou
2025-10-03 8:59 ` [PATCH 3/4] drm/bridge: document that adding a bridge is mandatory before attach Luca Ceresoli
2025-10-18 12:46 ` Raphaël Gallais-Pou
2025-10-03 8:59 ` [PATCH 4/4] drm/bridge: add warning for bridges attached without being added Luca Ceresoli
2025-10-18 12:46 ` Raphaël Gallais-Pou [this message]
2025-10-18 12:49 ` [PATCH 0/4] drm/bridge: enforce drm_bridge_add() before drm_bridge_attach() Raphaël Gallais-Pou
2025-10-21 21:05 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a822d284-f2a2-40f8-987a-6e2f70a22fcf@gmail.com \
--to=rgallaispou@gmail.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®