From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F98DC2BB48 for ; Thu, 17 Dec 2020 06:52:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DC8F23884 for ; Thu, 17 Dec 2020 06:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbgLQGwn (ORCPT ); Thu, 17 Dec 2020 01:52:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:9460 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgLQGwn (ORCPT ); Thu, 17 Dec 2020 01:52:43 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CxN2B4G3BzhrYm; Thu, 17 Dec 2020 14:51:30 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.498.0; Thu, 17 Dec 2020 14:51:57 +0800 Subject: Re: [PATCH] f2fs: fix out-of-repair __setattr_copy() To: Greg KH CC: , , , , References: <20201216091523.21411-1-yuchao0@huawei.com> From: Chao Yu Message-ID: Date: Thu, 17 Dec 2020 14:51:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/16 17:44, Greg KH wrote: > On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote: >> __setattr_copy() was copied from setattr_copy() in fs/attr.c, there is >> two missing patches doesn't cover this inner function, fix it. >> >> Commit 7fa294c8991c ("userns: Allow chown and setgid preservation") >> Commit 23adbe12ef7d ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid") > > Are these lines supposed to be "Fixes:" instead of "Commit "? IMO, the issue was introduced when f2fs module was added, and above two commits missed to cover f2fs module... so I guess we can add Fixes line as below? Fixes: fbfa2cc58d53 ("f2fs: add file operations") Thanks, > > thanks, > > greg k-h > . >