From: Waiman Long <longman@redhat.com>
To: Xiu Jianfeng <xiujianfeng@huawei.com>,
lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()
Date: Thu, 25 Apr 2024 08:24:46 -0400 [thread overview]
Message-ID: <a834a59d-9f31-4374-923f-ddd89780b62a@redhat.com> (raw)
In-Reply-To: <20240425093016.1068567-1-xiujianfeng@huawei.com>
On 4/25/24 05:30, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> kernel/cgroup/cpuset.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index f5443c039619..a10e4bd0c0c1 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
>
> buf = strstrip(buf);
>
> - /*
> - * Convert "root" to ENABLED, and convert "member" to DISABLED.
> - */
> if (!strcmp(buf, "root"))
> val = PRS_ROOT;
> else if (!strcmp(buf, "member"))
Yes, that comment is now no longer relevant.
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2024-04-25 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:30 Xiu Jianfeng
2024-04-25 12:24 ` Waiman Long [this message]
2024-04-25 17:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a834a59d-9f31-4374-923f-ddd89780b62a@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®