From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D2AC4332F for ; Wed, 9 Feb 2022 13:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234415AbiBINqZ (ORCPT ); Wed, 9 Feb 2022 08:46:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbiBINqN (ORCPT ); Wed, 9 Feb 2022 08:46:13 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6462DC05CB88 for ; Wed, 9 Feb 2022 05:46:15 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F36DC3F203 for ; Wed, 9 Feb 2022 13:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644414374; bh=uPmwK2Sajk0B7/rIDbd45YqogfWkOlduqJZAInEIkls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QZylIZK/ZbCM+lLoOmDxUTV/wvvbJGRBA1qr+UyvUKvedMwJFH1Ni4iBJ5NqoaSJz q8bFGfNOXaqDH4KJM47/M7hTYsTCmY/bNQIZtMUKBVnFKAUFxBoaYUppHpQKm7VIfp qtPi4eDLahZR6IPBmWdBM0szejygAy2WVpocOTB1aQ70uBuQnGEgSY4Z4QPcPKlPxd yZsMqEM0AgIV6BYwA03sAQQH2ZoZx/DrtHBWA0SY1r55Mjyy+Q8TKqMtQieAcICN8X XqXs/V2aW6IViqj2jg1rPhperEjG7cYhqoaRWz7VkRlGU0VqOMfbu9uVsFaIRWc2bu AYyPEWzeLKzdw== Received: by mail-ej1-f72.google.com with SMTP id z26-20020a1709067e5a00b006cbe0628826so1202900ejr.10 for ; Wed, 09 Feb 2022 05:46:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uPmwK2Sajk0B7/rIDbd45YqogfWkOlduqJZAInEIkls=; b=HtjUr8dZOKyude1unIY5P9gyGkaj9qF+WHM3uw1IrqUFAImM8ofP7Fl4wusY9fFrrF fr+9wcbVFUTfOsJzWeFhLkgOJA75TqT0sTUWoljTEx+CDPNMM6TQheAovwCACroe15cp gCbFoi1vscB90iCXI8UCfpTYbX/Z4A6CbCKpPDINkWsPLIS3cpMlHtmjnaHcyZtj9N8T ysAmPOSOR4DeVHHOFY4RINzxPXvYeXfqIaPni1xYU36WJ+KCt7Dx/ORZqqjUyhf/sGAw OPy2Bww5B63AGWoDBevIBL2BwmPPykA5QAF0+VqRUoaNzE3WybGe7rOUqMEuWmLGQ6ah qafw== X-Gm-Message-State: AOAM53068yAlAvZJX9XSwKade2HiUWExuKkt+QY6QxWbxe5SN4bW2q16 ARPil+5wrEVPT/T79vIvBatH4insjDgCigwqLIHMRodF1g2WI31IM0uUCH+uu350h5OFzA+xfQJ 8XSEajUmndrdc5HilHGb4AO8MCAODMYtLe6ry0MP7fA== X-Received: by 2002:a05:6402:3596:: with SMTP id y22mr2613087edc.370.1644414372806; Wed, 09 Feb 2022 05:46:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkZKjTUYePrgBC0lsw8CSQ+1aXWr69tlBK1fCM0/xVCywpwRzP01Ct4mgEz/qhm2ljFlSOXw== X-Received: by 2002:a05:6402:3596:: with SMTP id y22mr2613072edc.370.1644414372627; Wed, 09 Feb 2022 05:46:12 -0800 (PST) Received: from [192.168.0.94] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id i18sm2482081ejy.190.2022.02.09.05.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 05:46:11 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 14:46:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml Content-Language: en-US To: Corentin Labbe , davem@davemloft.net, heiko@sntech.de, herbert@gondor.apana.org.au, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20220209124725.2080986-1-clabbe@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220209124725.2080986-1-clabbe@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2022 13:47, Corentin Labbe wrote: > Convert rockchip-crypto to yaml. > > Signed-off-by: Corentin Labbe > --- > .../bindings/crypto/rockchip-crypto.txt | 28 -------- > .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++ > 2 files changed, 64 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > deleted file mode 100644 > index 5e2ba385b8c9..000000000000 > --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -Rockchip Electronics And Security Accelerator > - > -Required properties: > -- compatible: Should be "rockchip,rk3288-crypto" > -- reg: Base physical address of the engine and length of memory mapped > - region > -- interrupts: Interrupt number > -- clocks: Reference to the clocks about crypto > -- clock-names: "aclk" used to clock data > - "hclk" used to clock data > - "sclk" used to clock crypto accelerator > - "apb_pclk" used to clock dma > -- resets: Must contain an entry for each entry in reset-names. > - See ../reset/reset.txt for details. > -- reset-names: Must include the name "crypto-rst". > - > -Examples: > - > - crypto: cypto-controller@ff8a0000 { > - compatible = "rockchip,rk3288-crypto"; > - reg = <0xff8a0000 0x4000>; > - interrupts = ; > - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, > - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; > - clock-names = "aclk", "hclk", "sclk", "apb_pclk"; > - resets = <&cru SRST_CRYPTO>; > - reset-names = "crypto-rst"; > - }; > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml > new file mode 100644 > index 000000000000..392d89055398 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml file name: rockchip,crypto.yaml or rockchip,rk3288-crypto.yaml. Kind of depends whether there is another binding possible for newer Crypto blocks from Rockchip. I guess it is quite possible, so maybe the latter version. > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Electronics And Security Accelerator > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + const: rockchip,rk3288-crypto > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock data > + - description: clock data > + - description: clock crypto accelerator > + - description: clock dma > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: sclk > + - const: apb_pclk > + > + resets: > + minItems: 1 Instead maxItems: 1 > + > + reset-names: > + const: crypto-rst > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + crypto: crypto@ff8a0000 { > + compatible = "rockchip,rk3288-crypto"; > + reg = <0xff8a0000 0x4000>; > + interrupts = ; > + clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, > + <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; Does it work? Did you run dt_binding_check? > + clock-names = "aclk", "hclk", "sclk", "apb_pclk"; > + resets = <&cru SRST_CRYPTO>; > + reset-names = "crypto-rst"; > + }; Best regards, Krzysztof