From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Puma Hsu <pumahsu@google.com>, <mathias.nyman@intel.com>,
<gregkh@linuxfoundation.org>
Cc: <albertccwang@google.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: re-initialize the HC during resume if HCE was set
Date: Tue, 28 Dec 2021 17:34:05 +0300 [thread overview]
Message-ID: <a8377a4a-9a90-5c99-88b8-4541ff5b1ad9@omp.ru> (raw)
In-Reply-To: <20211228060246.2958070-1-pumahsu@google.com>
Hello!
On 12/28/21 9:02 AM, Puma Hsu wrote:
> When HCE(Host Controller Error) is set, it means an internal
> error condition has been detected. It needs to re-initialize
> the HC too.
>
> Signed-off-by: Puma Hsu <pumahsu@google.com>
> ---
> drivers/usb/host/xhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dc357cabb265..c546d9533410 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1146,8 +1146,8 @@ int xhci_resume(struct xhci_hcd *xhci, bool hibernated)
> temp = readl(&xhci->op_regs->status);
> }
>
> - /* If restore operation fails, re-initialize the HC during resume */
> - if ((temp & STS_SRE) || hibernated) {
> + /* If restore operation fails or HC error is detected, re-initialize the HC during resume */
> + if ((temp & STS_SRE) || (temp & STS_HCE) || hibernated) {
if ((temp & (STS_SRE | STS_HCE)) || hibernated) {
[...]
MBR, Sergey
next prev parent reply other threads:[~2021-12-28 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 6:02 Puma Hsu
2021-12-28 8:26 ` Greg KH
2021-12-29 5:53 ` Puma Hsu
2021-12-29 8:30 ` Greg KH
2021-12-29 9:11 ` Puma Hsu
2021-12-29 9:51 ` Greg KH
2021-12-29 10:21 ` Puma Hsu
2021-12-29 10:37 ` Greg KH
2021-12-28 14:34 ` Sergey Shtylyov [this message]
2021-12-29 5:55 ` Puma Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8377a4a-9a90-5c99-88b8-4541ff5b1ad9@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=albertccwang@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pumahsu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®